[desk-tool] Keep info about type mismatch, and do type mismatch check… #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… only for '*' + on cWRP
bjoerge
added a commit
that referenced
this pull request
Nov 2, 2017
… only for '*' + on cWRP (#311)
bjoerge
added a commit
that referenced
this pull request
Nov 2, 2017
… only for '*' + on cWRP (#311)
Merged
bjoerge
added a commit
that referenced
this pull request
Nov 2, 2017
… only for '*' + on cWRP (#311)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version we did automatic redirect whenever a document was attempted to be edited as a wrong type. This patch restores the original warning so the user is made aware of it, but instead adds a button that leads to the page for editing as correct type.
It also does the type mismatch check on componentWillReceiveProps. Which is needed in order to support intent links without type (for now). The type mismatch check will only trigger if type is
*(which I've tend to think of as "infer").