-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(titles): Update titles inside desk tool #4887
feat(titles): Update titles inside desk tool #4887
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
48336cc
to
b625399
Compare
Component Testing Report Updated Sep 6, 2023 5:28 AM (UTC)
|
b625399
to
8f0f3ca
Compare
aefe83b
to
5242d30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny tiny suggestion, otherwise looks great! Thanks @pedrobonamin!
5242d30
to
3ca28ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pedrobonamin – great work!
One minor issue is that the last document title isn't always displayed in the instance where multiple document panes are open. Here's an example link which should include "Zinken Hopsf!" in document.title
Once that's in I think this is good to go! I also submitted a PR against this which adds the above and refactors DeskTitle
slightly – would love your thoughts, but also feel free to disregard
When the user is moving through documents and panes, update the title property to be more specific to the current route
…ent pane title where applicable (#4898)
021f030
to
370a9d9
Compare
When the user is moving through documents and panes, update the title property to be more specific to the current route
Description
Update the
<title>
element to be more specific to the current route every time a user follows a link in the studio.Changes titles to use pipes as divider, in the title structure, mention first the most unique thing.
Test Studio - Content
Content | Test Studio
Uses the following pattern:
{{tool}} | {{desktoolTitle}}
{{paneTitle}} | {{desktoolTitle}}
{{documentTitle}} | {{desktoolTitle}}
New {{schemaTitle}} | {{desktoolTitle}}
What to review
Titles inside the studio, navigating through documents in the desk and also navigating between tools.
Notes for release
Update the <title> element to be more specific to the current route every time a user follows a link in the studio.
Titles.mov