Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a docs report actions for PRs #4889

Merged
merged 7 commits into from
Sep 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions .github/workflows/docReport.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
name: Create Documentation Report

on:
# Build on pushes branches that have a PR (including drafts)
pull_request:
# Build on commits pushed to branches without a PR if it's in the allowlist
push:
branches: [current]

jobs:
report:
runs-on: ubuntu-latest
env:
TURBO_TOKEN: ${{ secrets.VERCEL_TOKEN }}
TURBO_TEAM: sanity-io

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Cache node modules
id: cache-node-modules
uses: actions/cache@v3
env:
cache-name: cache-node-modules
with:
path: '**/node_modules'
key: ${{ runner.os }}-modules-${{ env.cache-name }}-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-modules-${{ env.cache-name }}-
${{ runner.os }}-modules-
${{ runner.os }}-

- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile

- name: Build packages
run: yarn build
env:
NODE_OPTIONS: --max_old_space_size=8192

- name: Create Docs Report on current
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/current' }}
env:
DOCS_REPORT_TOKEN: ${{ secrets.DOCS_REPORT_DATASET_TOKEN }}
DOCS_REPORT_DATASET: production
run: yarn docs:report:create

- name: Create Docs Report on PR
if: ${{ github.event_name == 'pull_request' }}
env:
DOCS_REPORT_TOKEN: ${{ secrets.DOCS_REPORT_DATASET_TOKEN }}
DOCS_REPORT_DATASET: ${{ github.ref_name }}
run: yarn docs:report:create

- name: Compare Docs Coverage on PR
if: ${{ github.event_name == 'pull_request' }}
env:
DOCS_REPORT_TOKEN: ${{ secrets.DOCS_REPORT_DATASET_TOKEN }}
DOCS_REPORT_DATASET: ${{ github.ref_name }}
run: yarn docs:report

- name: PR comment with report
uses: thollander/actions-comment-pull-request@d61db783da9abefc3437960d0cce08552c7c004f # v2
if: ${{ github.event_name == 'pull_request' }}
with:
comment_tag: 'docs-report'
filePath: ${{ github.workspace }}/scripts/docs-report.md
40 changes: 40 additions & 0 deletions .github/workflows/docReportTeardown.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
name: 'Cleanup: Documentation Report'

on:
# Build on closed or merged PRs
pull_request:
types: [closed]

jobs:
reportTeardown:
runs-on: ubuntu-latest
env:
TURBO_TOKEN: ${{ secrets.VERCEL_TOKEN }}
TURBO_TEAM: sanity-io

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Cache node modules
id: cache-node-modules
uses: actions/cache@v3
env:
cache-name: cache-node-modules
with:
path: '**/node_modules'
key: ${{ runner.os }}-modules-${{ env.cache-name }}-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-modules-${{ env.cache-name }}-
${{ runner.os }}-modules-
${{ runner.os }}-

- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile

- name: Remove datasets for closed PRs
env:
PERF_TEST_METRICS_TOKEN: ${{ secrets.PERF_TEST_SANITY_TOKEN }}
DOCS_REPORT_DATASET: $GITHUB_REF_NAME
run: yarn docs:report:cleanup
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,6 @@ etc
.yarn
.yarnrc
.turbo

## Documentation Report
scripts/docs-report.md
5 changes: 5 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@
"dev:starter-studio": "yarn --cwd dev/starter-studio dev",
"dev:strict-studio": "yarn --cwd dev/strict-studio dev",
"dev:test-studio": "yarn --cwd dev/test-studio dev",
"docs:report": "node -r dotenv-flow/config -r esbuild-register scripts/doc-report/docReport",
"docs:report:create": "node -r dotenv-flow/config -r esbuild-register scripts/doc-report/docReportCreate",
"docs:report:cleanup": "node -r dotenv-flow/config -r esbuild-register scripts/doc-report/docReportCleanup",
"eslint": "eslint --ext=.cjs,.js,.jsx,.mjs,.ts,.tsx --quiet",
"example:blog-studio": "yarn --cwd examples/blog-studio start",
"example:clean-studio": "yarn --cwd examples/clean-studio start",
Expand Down Expand Up @@ -83,6 +86,7 @@
"@babel/preset-env": "^7.19.1",
"@babel/preset-react": "^7.18.6",
"@babel/preset-typescript": "^7.18.6",
"@bjoerge/mutiny": "^0.0.2",
"@optimize-lodash/rollup-plugin": "^4.0.1",
"@playwright/test": "^1.37.0",
"@sanity/client": "^6.4.9",
Expand Down Expand Up @@ -131,6 +135,7 @@
"prettier-plugin-packagejson": "^2.4.5",
"pretty-quick": "^3.1.3",
"rimraf": "^3.0.2",
"rxjs": "^7.8.1",
"semver": "^7.3.5",
"turbo": "^1.10.12",
"typescript": "^5.1.6",
Expand Down
13 changes: 13 additions & 0 deletions scripts/doc-report/docClient.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import {type SanityClient, createClient} from '@sanity/client'
import {sanityIdify} from '../utils/sanityIdify'
import {readEnv} from './envVars'

export function createDocClient(dataset: string): SanityClient {
return createClient({
projectId: 'c1zuxvqn',
dataset: sanityIdify(dataset),
token: readEnv('DOCS_REPORT_TOKEN'),
apiVersion: '2023-02-03',
useCdn: false,
})
}
143 changes: 143 additions & 0 deletions scripts/doc-report/docReport.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,143 @@
import fs from 'fs/promises'
import path from 'path'
import {groupBy} from 'lodash'
import {combineLatest, map} from 'rxjs'
import {startTimer} from '../utils/startTimer'
import {createDocClient} from './docClient'
import {readEnv} from './envVars'

const QUERY = `*[_type=='exportSymbol'] {
_id,
"package": exportedBy->normalized,
"isDocumented": defined(versions[0].comment)
}
`

interface ExportSymbol {
_id: string
package: string
isDocumented: boolean
}

interface Report {
package: string
documented: number
notDocumented: number
}

interface TransformResult {
package: string
documentedChange: number
prodDocumented: number
prodNotDocumented: number
branchDocumented: number
branchNotDocumented: number
}

const studioMetricsClient = createDocClient(readEnv('DOCS_REPORT_DATASET'))
const studioMetricsClientProduction = createDocClient('production')

function getDocumentationReport(symbols: ExportSymbol[]): Report[] {
const obj = groupBy(symbols, 'package')

return Object.entries(obj).map(([key, val]) => {
// return total number of documented and not documented symbols
return {
package: key,
documented: val.filter((s) => s.isDocumented).length,
notDocumented: val.filter((s) => !s.isDocumented).length,
}
})
}

const timer = startTimer(`Fetching docs report`)

combineLatest([
studioMetricsClient.observable.fetch(QUERY),
studioMetricsClientProduction.observable.fetch(QUERY),
])
.pipe(
map(([branch, production]: [ExportSymbol[], ExportSymbol[]]): TransformResult[] => {
const branchGroup = getDocumentationReport(branch)
const productionGroup = getDocumentationReport(production)

// Compare the two groups and return percent difference
return branchGroup.map((br) => {
const prod = productionGroup.find((p) => p.package === br.package)

if (!prod) {
return {
package: br.package,
documentedChange: 0,
prodDocumented: 0,
prodNotDocumented: 0,
branchDocumented: br.documented,
branchNotDocumented: br.notDocumented,
}
}

const documentedPercentDiff = (br.documented - prod.documented) / prod.documented

return {
package: br.package,
documentedChange: Number.isNaN(documentedPercentDiff)
? 0
: Math.floor(documentedPercentDiff * 100),
prodDocumented: prod.documented,
prodNotDocumented: prod.notDocumented,
branchDocumented: br.documented,
branchNotDocumented: br.notDocumented,
}
})
}),
)
.subscribe(async (res) => {
// convert the result to a markdown table with heading
const table = `
| Package | Documentation Change |
| ------- | ----------------- |
${res
.sort((a, b) => b.documentedChange - a.documentedChange)
.filter((r) => r.documentedChange !== 0)
.map(
(r) =>
`| ${r.package} | ${
r.documentedChange > 0 ? `+${r.documentedChange}` : r.documentedChange
}% |`,
)
.join('\n')}

<details>
<summary>Full Report</summary>
${res
.sort((a, b) => b.documentedChange - a.documentedChange)
.map(
(r) =>
`<details>
<summary>${r.package}</summary>
<table>
<tr>
<th>This branch</th>
<th>Current release</th>
</tr>
<tr>
<td>${r.branchDocumented} documented</td>
<td>${r.prodDocumented} documented</td>
</tr>
<tr>
<td>${r.branchNotDocumented} not documented</td>
<td>${r.prodNotDocumented} not documented</td>
</tr>
</table>
</details>
`,
)
.join('\n')}
</details>
`

// save it to a file
await fs.writeFile(path.resolve(path.join(__dirname, '..', 'docs-report.md')), table, 'utf8')

timer.end()
})
19 changes: 19 additions & 0 deletions scripts/doc-report/docReportCleanup.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import {sanityIdify} from '../utils/sanityIdify'
import {createDocClient} from './docClient'
import {readEnv} from './envVars'

const DATASET = readEnv('DOCS_REPORT_DATASET')
const studioMetricsClient = createDocClient(DATASET)

studioMetricsClient.datasets
.delete(sanityIdify(DATASET))
.then((res) => {
if (res.deleted) {
console.log('Deleted dataset')
} else {
console.log('Dataset was not deleted')
}
})
.catch((err) => {
console.error(`Something went wrong! ${err?.response?.body?.message}`)
})
Loading
Loading