Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(WCAG): Associate field descriptions to inputs #4896

Merged
merged 6 commits into from
Sep 13, 2023
Merged

feat(WCAG): Associate field descriptions to inputs #4896

merged 6 commits into from
Sep 13, 2023

Commits on Sep 8, 2023

  1. feat(WCAG): Associate field descriptions to inputs

    @pedrobonamin
    pedrobonamin committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    39b2979 View commit details
    Browse the repository at this point in the history

  2. feat(WCAG): Adds aria-describedby to PTE

    @pedrobonamin
    pedrobonamin committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    5c7efbf View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. feat(WCAG): Rename PT prop and change constructDescriptionId for crea… 

    …teDescriptionId
    @pedrobonamin
    pedrobonamin committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    e7355a6 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. fix(portable-text-editor): forward html attributes to editable component 

    This will forward html props for the editable element to the slate editable.
It will also get rid of the need of having an own wrapper div element to
put the ref on. Point it directly on the editable element.
    @skogsmaskin
    skogsmaskin committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    f856a7a View commit details
    Browse the repository at this point in the history

  2. test(portable-text-editor): update snapshot

    @skogsmaskin
    skogsmaskin committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    e846d0f View commit details
    Browse the repository at this point in the history

  3. refactor(portable-text-editor): remove unnecessary memo 

    This doesn't need to be memoed, at least not after supporting restProps here.

Debugging shows that the nodes inside are not re-rendered by removing this memo,
which is what we care about.
    @skogsmaskin
    skogsmaskin committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    f1c2e5e View commit details
    Browse the repository at this point in the history