feat(tasks): bootstrap tasks plugin #5704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobonamin
requested review from
ninaandal and
cngonzalez
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
pedrobonamin
force-pushed
the
edx-986-plugin
branch
2 times, most recently
from
f15d112
to
82075f1
Compare
|
No changes to documentation |
pedrobonamin
force-pushed
the
edx-986-plugin
branch
from
82075f1
to
c836bdc
Compare
pedrobonamin
force-pushed
the
edx-986-plugin
branch
from
c836bdc
to
5772cca
Compare
|
Component Testing Report Updated Mar 8, 2024 4:57 PM (UTC)
|
pedrobonamin
force-pushed
the
edx-986-plugin
branch
from
5772cca
to
0e1087b
Compare
pedrobonamin
force-pushed
the
edx-986-plugin
branch
from
0e1087b
to
865634e
Compare
pedrobonamin
force-pushed
the
edx-986-plugin
branch
from
865634e
to
12fea46
Compare
This reverts commit 958a202.
pedrobonamin
force-pushed
the
edx-986-plugin
branch
from
7a59706
to
68880ea
Compare
sjelfull
approved these changes
Mar 8, 2024
packages/sanity/src/tasks/src/tasks/components/list/TasksListItem.tsx
Outdated
Show resolved
Hide resolved
| const {activeDocumentId} = useTasks() | ||
| const [isDisabledTab, setIsDisabledTab] = useState<boolean>(!activeDocumentId) | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
Agree, we could probably refactor it to a observable, for example. I'll come up with a suggestion.
packages/sanity/src/structure/comments/src/components/pte/comment-input/CommentInputInner.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/tasks/src/tasks/components/form/DescriptionInput.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/tasks/src/tasks/components/form/RemoveTask.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/tasks/src/tasks/components/list/TasksList.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Fred Carlsen <fred@sjelfull.no>
…ate enabled checks
pedrobonamin
force-pushed
the
edx-986-plugin
branch
from
f516d8b
to
422613c
Compare
juice49
pushed a commit
that referenced
this pull request
Mar 13, 2024
* feat(tasks): feature bootstrap, add initial setup * fix(tasks): rename tasks provider actions, update tasks sidebar component * fix(tasks): enable tasks in staging, remove from prod * feat(core): add tasks data loading Signed-off-by: Fred Carlsen <fred@sjelfull.no> * refactor(tasks): move things around Signed-off-by: Fred Carlsen <fred@sjelfull.no> * feat(tasks): add support for showing document tasks Signed-off-by: Fred Carlsen <fred@sjelfull.no> * fix: add types and export internal tag to tasks exports * chore(tasks): move files for plugin implementation * chore(tasks): add tasks export path sanity/tasks * feat(core): add studioNavbar rightSectionNode prop * feat(tasks): import tasks as a plugin * fix(tasks): setup workshop * fix(tasks): rename component files to tasks * fix(tasks): rename workshop folder * fix(tasks): get createtask workshop story to show * feat(tasks): add tasks create view * fix(tasks): update TasksSetupProvider to return client instead of creating document * feat(tasks): add tasks creation action * feat(tasks): add tasks remove and edit * feat(tasks): support document references Signed-off-by: Fred Carlsen <fred@sjelfull.no> * fixup! feat(tasks): support document references Signed-off-by: Fred Carlsen <fred@sjelfull.no> * fixup! feat(tasks): support document references Signed-off-by: Fred Carlsen <fred@sjelfull.no> * fix(tasks): set activeTab created when creating tasks * fix(tasks): reset to created tab on delete Signed-off-by: Fred Carlsen <fred@sjelfull.no> * fix(tasks): disable sidebar animation Signed-off-by: Fred Carlsen <fred@sjelfull.no> * fix(tasks): small visual tweaks to task lists Signed-off-by: Fred Carlsen <fred@sjelfull.no> * feat(tasks): add document navigation from tasks * fix(tasks): update breaking types definitions * fix(tasks): add status to task * fix(tasks); sort tasks based on status * fix(tasks): run lint:fix * fix(tasks): update navbarProp * fix(tasks): add loadingstate to taskstatus * feat(tasks): add assignee property to tasks * Revert "chore(tasks): add tasks export path sanity/tasks" This reverts commit eec41ca. * chore(tasks): add tasks export path sanity/tasks * fix(tasks): add exports definitions * fix(tasks): small fixes * feat(tasks): add feature flag check * fix(tasks): fix type issue Signed-off-by: Fred Carlsen <fred@sjelfull.no> * fix(tasks): utilise document preview store for document titles Signed-off-by: Fred Carlsen <fred@sjelfull.no> * fix(tasks): center loading spinner Signed-off-by: Fred Carlsen <fred@sjelfull.no> * fix(tasks): revert type change * fix(tasks): move styledIntentLink * fix(tasks): show 'untitled' if title is undefined * chore(tasks): create DescriptionInput * feat(tasks): support adding related documents in tasks * chore(tasks): add tasks codeowners * fix(tasks): update to useUserListWithPermission * chore(tasks): refactor file location, rename some, prepare PR * chore(tasks): reuse addonDatasetProvider, remove tasksSetupProvider * fix(tasks): add comment to tasksListTabs and rename state * fix(tasks): remove update function from tasksOperation * feat(tasks): update navigation styles, add header navigation * fix(tasks): move tasks sidebar navigation to it's own context * feat(tasks): add badge implementation of pending tasks * Revert "chore(tasks): add tasks export path sanity/tasks" This reverts commit 958a202. * fix(tasks): type error * chore(tasks): change created tab for subscribed tab in tasks navigation * chore(tasks): small ui fixes * fix(tasks): refactor tasksNavigation to a reducer, simplify state handling * refactor(tasks): include tasks plugin via config flag (#5935) Signed-off-by: Fred Carlsen <fred@sjelfull.no> * fix(tasks): update pr with suggestions * fix(tasks): fix build issue, import plugin into structure plugin, update enabled checks --------- Signed-off-by: Fred Carlsen <fred@sjelfull.no> Co-authored-by: Fred Carlsen <fred@sjelfull.no> Co-authored-by: Nina Andal Aarvik <nina@sanity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Necessary PRs
Introduces initial WIP
Tasksplugin.Taskswill allow users to create and assign actions to users or themselves, linking documents if desired.This is an initial implementation, design is still in progress.
The intention of this PR is to bring the main plugin changes to main, helping the team move faster and not depend on a feature branch, pushing for more atomic changes, is not the final and stable implementation.
The components and functionality consumed in
Tasksfrom Comments will be refactored once the FormBuilder changes are introduced.Implemented changes:
Not implemented yet, will be added later.
router.Formin tasks, to support live editing and presence.What to review
sanity/tasksadded.Testing
Notes for release