feat(core): rename useMentionOptions to useUserListWithPermission and move to core #5778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
5 tasks
pedrobonamin
force-pushed
the
edx-1110
branch
from
e6156bd
to
0b98185
Compare
|
No changes to documentation |
|
Component Testing Report Updated Feb 19, 2024 3:17 PM (UTC)
|
pedrobonamin
force-pushed
the
edx-1110
branch
from
0b98185
to
bafabf3
Compare
pedrobonamin
force-pushed
the
edx-1110
branch
from
bafabf3
to
0bda28a
Compare
pedrobonamin
requested review from
ninaandal,
rexxars and
hermanwikner
and removed request for
a team
hermanwikner
approved these changes
Feb 19, 2024
pedrobonamin
force-pushed
the
edx-1110
branch
from
df053fa
to
6a5b444
Compare
juice49
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
useMentionOptionshook was introduced into comments plugin.This hook, fetches the project list of users and validates if the user has the desired permission for the provided document.
Renames the hook to
useUserListWithPermission, suggestions accepted.We need to reuse that same logic in the
Tasksplugin, moving this tocoreaims to keep things centralised and shared across this two plugins.Main change:
File moved to core
What to review
Is comments working the same as before?
Is this name clear and correct?
Is the location of the hook correct?
Testing
Notes for release
Adds
useUserListWithPermissionreusable hook intocore