Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(structure): allow sanity.previewUrlSecret in document lists #5733

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Feb 14, 2024

Description

The #5657 PR didn't manage to fix the regression in #5440. With the help of @sjelfull this time it's actually resolved and the fix reproducible on the Test Studio.

What to review

Adding sanity.previewUrlSecret should only have an effect on this particular type, other sanity. prefixed types shouldn't show up anywhere, like in global search.

Testing

In a Studio that has this plugin installed:

import {debugSecrets} from '@sanity/preview-url-secret/sanity-plugin-debug-secrets'
import {defineConfig} from 'sanity'

export default defineConfig({
  // ...
  plugins: [
    debugSecrets()
  ]
})

Then Structure tool should show this menu:
image
And global search should let you filter by the type as well:
image

When the plugin isn't used then these document types should remain hidden:
image

Notes for release

  • fixed regression that affected import {debugSecrets} from '@sanity/preview-url-secret/sanity-plugin-debug-secrets' from listing secrets

@stipsan stipsan requested review from a team as code owners February 14, 2024 13:55
@stipsan stipsan requested review from pedrobonamin and juice49 and removed request for a team February 14, 2024 13:55
Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 15, 2024 4:56pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 4:56pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 4:56pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 14, 2024

Component Testing Report Updated Feb 15, 2024 5:01 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 17s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ❌ Failed (Inspect) 1m 4s 17 0 1
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

Copy link
Contributor

@juice49 juice49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 🚀 Just need to sync the branch with next.

Signed-off-by: Fred Carlsen <fred@sjelfull.no>
@juice49 juice49 deleted the fix/allow-previewsecret-in-document-lists branch February 15, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants