Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression caused by #5440 #5657

Merged
merged 2 commits into from
Feb 2, 2024
Merged

fix: regression caused by #5440 #5657

merged 2 commits into from
Feb 2, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Feb 2, 2024

Description

In #5440, released in v3.24.1, the debug URL secrets feature broke.
When using sanity/presentation it's possible to view generated URL secrets.

On versions 3.23.4 and older it works fine:
image

Updating to v3.24.1, or all the way up to v3.27.1, then the list is empty:
image

What to review

The regression fix shouldn't cause further regressions. For example it's not desirable that url preview secrets shows up in the global search. We just want a way for it to show up when the debug plugin is added to the config:

import { defineConfig } from 'sanity'
import { debugSecrets } from '@sanity/preview-url-secret/sanity-plugin-debug-secrets'

export default defineConfig({
  // ... other options
  plugins: [
    // Makes the url secrets visible in the Sanity Studio like any other documents defined in your schema
    debugSecrets(),
  ],
})

The plugin loads this schema.

Testing

Create a document of the sanity.previewUrlSecret type, and after loading the plugin as outlined above the document should show up in the Structure document list.

Notes for release

fix: regression that broke @sanity/preview-url-secret/sanity-plugin-debug-secrets in v3.24.1

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ❌ Failed (Inspect) Feb 2, 2024 4:02pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 4:02pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2024 4:02pm

Copy link
Contributor

github-actions bot commented Feb 2, 2024

No changes to documentation

@stipsan stipsan marked this pull request as ready for review February 2, 2024 15:19
@stipsan stipsan requested a review from a team as a code owner February 2, 2024 15:19
@stipsan stipsan requested review from jtpetty and removed request for a team February 2, 2024 15:19
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Component Testing Report Updated Feb 2, 2024 4:06 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 19s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@stipsan stipsan added this pull request to the merge queue Feb 2, 2024
Merged via the queue into next with commit 0af205c Feb 2, 2024
39 of 40 checks passed
@stipsan stipsan deleted the fix-query-regression branch February 2, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants