fix(tasks): show pending tasks in document footer #5894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Mar 12, 2024 12:24 PM (UTC)
|
pedrobonamin
force-pushed
the
edx-986-plugin
branch
from
e1a6a23
to
ac8dcca
Compare
ninaandal
requested review from
sjelfull,
juice49 and
pedrobonamin
and removed request for
a team
pedrobonamin
reviewed
Mar 7, 2024
There was a problem hiding this comment.
Thanks for this @ninaandal, great work!
Suggested some tiny changes that we will need to update.
packages/sanity/src/structure/panes/document/statusBar/DocumentStatusBarActions.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/structure/comments/plugin/input/components/InlineCommentInputPopover.tsx
Outdated
Show resolved
Hide resolved
pedrobonamin
force-pushed
the
edx-986-plugin
branch
3 times, most recently
from
7a59706
to
68880ea
Compare
5 tasks
juice49
reviewed
Mar 12, 2024
juice49
reviewed
Mar 12, 2024
juice49
reviewed
Mar 12, 2024
juice49
approved these changes
Mar 12, 2024
juice49
pushed a commit
that referenced
this pull request
Mar 13, 2024
* fix(tasks): show pending tasks in document footer * fix(tasks): add button to open tasks * fix(tasks): remove comment * fix(tasks): move out of document * fix(tasks): add conditional to tasks footer * fix(tasks): fix ts error * fix(tasks): update pr with comments * fix(tasks): keep task sidebar open if clicked on badge * fix(tasks): pluralize task text * fix(tasks): change React.ReactNode for ReactNode and remove data-as from button --------- Co-authored-by: Pedro Bonamin <pedrobonamin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new tasks config for the tasks plugin.
It also integrates into this footerAction the component to show how many pending tasks the document has, and open the tasks sidebar by clicking that button.
What to review
Is the configPropertyReducer implemented correctly?
Testing
Notes for release