Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): export useWorkspaceLoader from core #5898

Merged
merged 1 commit into from Mar 4, 2024

Conversation

pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented Mar 4, 2024

Description

This PR splits the logic in WorkspaceLoader from the provider to export a reusable hook from core useWorkspaceLoader(), this hook will allow the use of a custom workspace loader from within the studio.
It's necessary to use the AddonWorkspace in the tasks feature.

What to review

Could this be done different?

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner March 4, 2024 15:49
@pedrobonamin pedrobonamin requested review from binoy14 and removed request for a team March 4, 2024 15:49
Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 4, 2024 3:49pm
test-studio ✅ Ready (Inspect) Visit Preview Mar 4, 2024 3:49pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Mar 4, 2024 3:49pm

Copy link
Contributor

github-actions bot commented Mar 4, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Component Testing Report Updated Mar 4, 2024 3:57 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 58s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 0s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

Copy link
Contributor

@binoy14 binoy14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, not very familiar if it should be exported or not but since it's internal assuming it's fine.

Also I would remove the release notes about this since it's internal

@pedrobonamin pedrobonamin added this pull request to the merge queue Mar 4, 2024
Merged via the queue into next with commit 3670459 Mar 4, 2024
40 checks passed
@pedrobonamin pedrobonamin deleted the edx-1088-workspace-loader branch March 4, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants