feat(tasks): use FormBuilder to create and edit tasks. #5897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobonamin
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
pedrobonamin
changed the title
|
Component Testing Report Updated Mar 12, 2024 2:31 PM (UTC)
|
pedrobonamin
force-pushed
the
edx-986-plugin
branch
from
e1a6a23
to
ac8dcca
Compare
pedrobonamin
force-pushed
the
edx-986-plugin
branch
from
d8e8ada
to
aec133e
Compare
* fix(tasks): add activities to the activity log * fix(tasks): fix string logic of activities * fix(tasks): update activity components * fix(tasks): remove activity log dummy data * fix(tasks): update activity logs to work with comments --------- Co-authored-by: Pedro Bonamin <pedrobonamin@gmail.com>
…iders, move useTasksOperations
juice49
pushed a commit
that referenced
this pull request
Mar 13, 2024
* feat(tasks): add tasks creation action
* feat(tasks): WIP - use FormBuilder in tasks
* feat(tasks): use FormBuilder in tasks, fix remount issues
* feat(tasks): add missing fields to tasks
* feat(tasks): add custom title field
* feat(tasks): add mention options and fix assigned to field
* feat(tasks): wip implementation - use tasks reference with search
* fix: fix build issues
* fix(tasks): styling tasks create form
* fix(tasks): assign target content when a task is created with a document in view
* fix(tasks): update title styling
* fix(tasks): update focus visible on intent link
* fix(tasks): use commentInput in tasks description
* fix(tasks): update style for targetField placeholder
* {wip} saved 2024-02-27 15:41
* feat(tasks): start form edit work
* fix(tasks): move selected document logic
* feat(tasks): add wip activity log
* fix(tasks): update tasks ui
* feat(tasks): integrate remove tasks into the new edit form
* feat(tasks): add support for drafts and tasks duplication
* fix(tasks): updates post rebase with base branch
* fix(tasks): update tasks workspace provider, small fixes
* fix: remove unnecessary import
* fix(tasks): update assignee form field
* fix(tasks): add subscriptions to tasks
* fix(tasks): code cleanup
* fix(tasks): show subscribed tasks in subscribe tab
* fix(tasks): set creator of task as subscriber
* fix(tasks): not show avatars if no subscribers
* feat(tasks): add subscribers when editing and creating a task
* fix(tasks): update assignee fields, and add animation to subscribers
* chore(tasks): move target content field to the top
* fix(tasks): add assigned user to subscribers
* feat(tasks): add listener for query params, handle copy link
* fix(tasks): fix issue in which the tasks created were not saving the created value
* fix(tasks): rename mention user folder
* fix(tasks): add date field in edit form
* fix(tasks): add discard draft action
* feat(tasks): add comments
* fix(tasks): add activities to the activity log (#5929)
* fix(tasks): add activities to the activity log
* fix(tasks): fix string logic of activities
* fix(tasks): update activity components
* fix(tasks): remove activity log dummy data
* fix(tasks): update activity logs to work with comments
---------
Co-authored-by: Pedro Bonamin <pedrobonamin@gmail.com>
* fix(tasks): update tasks activity log UI
* chore(tasks): simplify form, reorganise files
* chore(tasks): update tasks header
* fix(tasks): ui tweaks (#5947)
* feat(tasks): add create task action from document (#5950)
* feat(tasks): responsive sidebar (#5949)
* fix(tasks): enable check for document action (#5958)
* fix(tasks): update remove task dialog text, update task list item ui
* fix(tasks): use TaskIcon from @sanity/icons
* fix(tasks): support for disabling tasks, add default value to useProviders, move useTasksOperations
* fix(tasks): hide active tab navigation when it's empty
* fix(tasks): sidebar z-index
* fix(tasks): turn on by default tasks config flag
* fix(tasks): add support for mobile footer action
---------
Co-authored-by: Nina Andal Aarvik <nina@sanity.io>
Co-authored-by: Herman Wikner <wiknerherman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Necessary PRs:
Not
tasksspecific.AddonDatasetProviderto export areadyprop, which indicates that the initial load has ended.data-ui=fieldHeaderContentBoxinto FormFieldBaseHeader to allow selecting that element and update styling accordingly.TasksspecificFormBuilderinto tasks, by inserting a new AddonWorkspaceProvider and replicating the form builder logic which currently lives only in thePaneProvider.drafts,duplicatetasks.TasksNavigationto supportcopy linkaction.Introduces two different form for tasks, which are handled by the
tasksSchema.Create form
Will be used when creating a new one, duplicating or editing a draft.
Edit form
Will be used when editing a task, this form has support for
commentsandactivityLogWhat to review
Overall functionality.
Is there any harm in importing components from core into the plugin when they are not exported from
core? See date inputTesting
Notes for release
Introduces drafts, duplicate, updated navigation and new form for tasks. Adds supports for comments and activity log in tasks.