feat(tasks): track activity changes with document history. #5965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
3 tasks
pedrobonamin
force-pushed
the
edx-1088
branch
2 times, most recently
from
2a03eab
to
2880abf
Compare
Signed-off-by: Fred Carlsen <fred@sjelfull.no>
pedrobonamin
force-pushed
the
feat/edx-1137
branch
from
046858d
to
0ff5462
Compare
|
No changes to documentation |
|
Component Testing Report Updated Mar 12, 2024 4:52 PM (UTC)
|
pedrobonamin
force-pushed
the
feat/edx-1137
branch
from
0ff5462
to
e40e258
Compare
pedrobonamin
requested review from
jtpetty and
ninaandal
and removed request for
a team
pedrobonamin
force-pushed
the
feat/edx-1137
branch
from
e40e258
to
0f3fdac
Compare
pedrobonamin
commented
Mar 12, 2024
| * @param fieldsToTrack - The fields to track for changes. | ||
| * @returns An array of changes for the tracked fields. | ||
| */ | ||
| export function trackFieldChanges( |
There was a problem hiding this comment.
Would be nice to have some tests added to this next week @sjelfull
jtpetty
reviewed
Mar 12, 2024
|
|
||
| const queryParams = `tag=sanity.studio.tasks.history&effectFormat=mendoza&excludeContent=true&includeIdentifiedDocumentsOnly=true&reverse=true` | ||
| const transactionsUrl = client.getUrl( | ||
| `/data/history/${dataset}/transactions/${task._id}?${queryParams}`, |
There was a problem hiding this comment.
is task._id always guaranteed to be URL safe?
There was a problem hiding this comment.
It should always return a published id, so it should be safe, but I will modify it to force the use of a published id here, in case we enable the drafts later in the process.
Thanks
jtpetty
approved these changes
Mar 12, 2024
…warnings generated
pedrobonamin
force-pushed
the
feat/edx-1137
branch
from
9a020bd
to
a50eba7
Compare
juice49
pushed a commit
that referenced
this pull request
Mar 13, 2024
* feat(tasks): track task changes with document history Signed-off-by: Fred Carlsen <fred@sjelfull.no> * feat(tasks): update tasks activity log to display values * fix(tasks): always fetch publishedId, add client api version * fix(tasks): update status selector and workspace provider to disable warnings generated --------- Signed-off-by: Fred Carlsen <fred@sjelfull.no> Co-authored-by: Fred Carlsen <fred@sjelfull.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tasks activity log.
Shows history changes made by users.
What to review
Testing
Notes for release