Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tasks): add new sanityTasks flag #6089

Merged
merged 2 commits into from
Mar 20, 2024
Merged

fix(tasks): add new sanityTasks flag #6089

merged 2 commits into from
Mar 20, 2024

Conversation

pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented Mar 20, 2024

Description

Add new sanityTasks flag.
We are introducing a new flag to require this version of the studio in order to get the tasks feature enabled.
We are keeping the staging flag until the new flag is added to production and staging.

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner March 20, 2024 15:30
@pedrobonamin pedrobonamin requested review from sjelfull and jtpetty and removed request for a team March 20, 2024 15:30
Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 20, 2024 3:51pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 3:51pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 3:51pm

enabled: true,
mode: 'default',
enabled: false,
mode: null,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This in the future will return mode upsell that's why it's on a different return

Copy link
Contributor

No changes to documentation

Copy link
Contributor

@jtpetty jtpetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Mar 20, 2024

Component Testing Report Updated Mar 20, 2024 3:53 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 0s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 20s 9 0 0

@pedrobonamin pedrobonamin added this pull request to the merge queue Mar 20, 2024
Merged via the queue into next with commit ae89244 Mar 20, 2024
34 of 36 checks passed
@pedrobonamin pedrobonamin deleted the tasks-feature-flag branch March 20, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants