fix(i18n): allow list formatter without arguments in Translate
component
#6135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems we used a formatter in a resource passed to
<Translate>
, which won't work as the "simple parser" does not reimplement all the logic from i18next. I initially did an approach where I changed the key to not use a formatter, but it quickly got a bit messy to think about whether the key should be a new key, and how to reason about old versions of it.Instead, I chose to implement partial support for formatters inside of the
Translate
component - currently only for thelist
formatter, and only without arguments. In time we can see if we can expand on this, but this fixes #6003 and moves us a bit forward at least.What to review
Testing
Notes for release