fix: statusButton requires provided aria-label #6430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Apr 29, 2024 11:23 AM (UTC)
|
jtpetty
reviewed
Apr 19, 2024
jordanl17
force-pushed
the
EDX-1147-statusButton-aria-label
branch
from
1f6a269
to
29d788c
Compare
jordanl17
force-pushed
the
EDX-1147-statusButton-aria-label
branch
from
29d788c
to
946fa0a
Compare
Co-authored-by: cngonzalez <3969996+cngonzalez@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat(typegen): also search for queries in app and sanity folders * feat(typegen): format generated types with prettier
* chore: upgrade groq-js * chore: always bump groq-js
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat(portable-text-editor): improve range decorations perf by comparing prev values * test(portable-text-editor): add tests for range decorations rendering * fixup! feat(portable-text-editor): improve range decorations perf by comparing prev values * test(portable-text-editor): improve some minor test things * fix(core): update z-index on PTE activate overlay * feat(core): extend presence data model with `selection` * feat(structure): include `selection` in presence data * feat(core): implement presence cursors in PTE * test(core): add presence cursor workshop story * refactor(core): use `getTheme_v2` to access theme values * fix(core): introduce `OnPathFocusPayload` to improve typing * fix(form/inputs): perf optimization for PT-input decorators * refactor(form/inputs): also display user presence when user is selecting a range, but only the focus point of it * fix(core): render presence cursors inline instead of in a portal * fix(core): broken workshop story * feat(core): reset presence selection on blur in PTE * fix(structure): add accidentially removed setFocusPath (DocumentPaneProvider) This seems to have been lost in a rebase. * fix(core): use `useFormFieldPresence` in `usePresenceCursorDecorations` * fix(core): set `focusPath` when receiving a mutation event if there are pending patches * fix(form/inputs): break don't return * fix(form/inputs): remove ref that should not be set here This ref is supposed to be set elsewhere (on the PTE Editable component) See eca960e * fix(form/inputs): sort hook deps list * fix(form/inputs): reconcile presence decorations for PT-Input Make sure these objects stays as stable as possible in order to not redraw any range decorations unnecessary. * fix(form/inputs): return early if focusPath is already selected in PT-Input * refactor(form/inputs): throttle reporting of focusPath and presence updates for PT-input * fix(core): import of `FormNodePresence` * fix(form/inputs): remove lastActive as dep for PT-presence range decorations uniqueness We are not using this value anyway, and it complicates the reconciliation of the presence decorators * test(core): add presence cursor workshop story * fix(core): remove unnecessary z-index in PTE activate overlay * fix(core): prevent presence cursor user name from being selected * fix(form/inputs): fix issue where perf opt on focusPath tracking broke tests This perf opt. broke some tests. It's not clear if it is a problem with the test or the func. so restoring the old behaviour for now. * test(core): update snapshots in `Studio.test` * refactor(core): move presence decorations according to user edits Use a own state for this. * refactor(core/form): remove complexity from PortableTextInput Handle debouncing in the DocumentProvider instead. Setting focusPath must be synchronous * refactor(structure): announce presence throttled When we introduced presence in the PortableTextInput, we risk calling the presence updates very often. There should be no reason for not doing this throttled, as long as we have leading true. * refactor(core): clean up presence cursors code + add comments --------- Co-authored-by: Per-Kristian Nordnes <per.kristian.nordnes@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: rexxars <48200+rexxars@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
RitaDias
reviewed
Apr 29, 2024
| @@ -48,7 +55,7 @@ export const StatusButton = forwardRef(function StatusButton( | |||
| <StyledButton | |||
| data-ui="StatusButton" | |||
| {...restProps} | |||
| aria-label={label || t('status-button.aria-label')} | |||
| aria-label={label} | |||
There was a problem hiding this comment.
Maybe I'm misunderstanding, but in this case wouldn't it be wise to still have a fall back on the StatusButton itself (outside of making sure that the labels exist where the StatusButton is used?)
There was a problem hiding this comment.
Would a fallback be necessary given that the aria-label is now a required prop?
There was a problem hiding this comment.
Oh yeah that's true! 🤔
I guess my follow up question is whether this should be something that we should require of all buttons then (if we don't already). Since it might be strange that we're only requiring this on a StatusButton vs everywhere else.
But maybe it's a question for another time and out of scope for this PR? 🤔
There was a problem hiding this comment.
That's a fair point! I'm not sure the situation with all other buttons but I can take a look after this PR. I'm not sure the exact process that surfaced this particular status button issue, but perhaps this was seem most commonly for now
|
Possible nitpick but for making things easier for folks on release/editorial:
If we're working on a fix the way Editorial tends to pose it is like "Fixes (...)" |
cngonzalez
added a commit
that referenced
this pull request
May 8, 2024
* fix: statusButton requires provided aria-label * fix: commenting on the new translation mapping added * chore(deps): dedupe pnpm-lock.yaml (#6463) Co-authored-by: cngonzalez <3969996+cngonzalez@users.noreply.github.com> * chore(deps): update dependency @sanity/pkg-utils to v6.8.4 (#6460) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(cli): mock matchMedia window function (#6472) * chore: add perf runner to workspace (#6427) * fix(typegen): fixes a bug where we imported the wrong relative path (#6457) * chore(deps): update dependency @sanity/tsdoc to v1.0.39 (#6464) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(typegen): also search for queries in app and sanity folders (#6475) * feat(typegen): also search for queries in app and sanity folders * feat(typegen): format generated types with prettier * chore: upgrade groq-js (#6474) * chore: upgrade groq-js * chore: always bump groq-js * chore(deps): dedupe pnpm-lock.yaml (#6476) Co-authored-by: github-merge-queue[bot] <118344674+github-merge-queue[bot]@users.noreply.github.com> * chore(deps): update dependency @sanity/visual-editing to v1.8.15 (#6465) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency @sanity/react-loader to v1.9.14 (#6466) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency date-fns-tz to v2.0.1 (#6467) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency i18next to v23.11.2 (#6468) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency zod to v3.23.4 (#6470) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency next to v14.2.2 (#6469) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency react-focus-lock to v2.12.1 (#6471) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @sanity/pkg-utils to v6.8.6 (#6482) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update react monorepo (#6484) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @sanity/tsdoc to v1.0.40 (#6483) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @sanity/presentation to v1.12.8 (#6485) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update react monorepo to ^18.3.0 (#6490) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency @types/react-is to v18.3.0 (#6491) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: setup next test that embeds the test studio (#6487) * chore: setup next test that embeds the test studio * chore: support HMR same way test-studio does * refactor: replace deprecated `empty()` with `EMPTY` * refactor: shorter `pnpm dev:next-studio` alias * chore: add `dev:turbo-studio` to test with turbopack * chore: remove unused * fix(test): remove hydrateroot warning test (#6494) * chore(deps): dedupe pnpm-lock.yaml (#6493) Co-authored-by: github-merge-queue[bot] <118344674+github-merge-queue[bot]@users.noreply.github.com> * feat: set print width to 40 (#6068) * chore(deps): update dependency @sanity/pkg-utils to v6.8.7 (#6496) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency turbo to ^1.13.3 (#6497) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency @sanity/logos to v2.1.11 (#6498) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency @sanity/react-loader to v1.9.15 (#6499) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(cli): remove comments from moviedb template, hide location field (#6488) * fix(search): revert to old search API for now (#6503) * v3.39.1 * chore(deps): dedupe pnpm-lock.yaml (#6463) Co-authored-by: cngonzalez <3969996+cngonzalez@users.noreply.github.com> * chore(deps): update dependency @sanity/pkg-utils to v6.8.4 (#6460) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: add perf runner to workspace (#6427) * chore(deps): update dependency @sanity/tsdoc to v1.0.39 (#6464) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: upgrade groq-js (#6474) * chore: upgrade groq-js * chore: always bump groq-js * chore(deps): dedupe pnpm-lock.yaml (#6476) Co-authored-by: github-merge-queue[bot] <118344674+github-merge-queue[bot]@users.noreply.github.com> * chore(lockfile): update dependency @sanity/react-loader to v1.9.14 (#6466) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency i18next to v23.11.2 (#6468) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency zod to v3.23.4 (#6470) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency next to v14.2.2 (#6469) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency react-focus-lock to v2.12.1 (#6471) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @sanity/pkg-utils to v6.8.6 (#6482) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update react monorepo (#6484) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @sanity/tsdoc to v1.0.40 (#6483) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @sanity/presentation to v1.12.8 (#6485) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update react monorepo to ^18.3.0 (#6490) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: setup next test that embeds the test studio (#6487) * chore: setup next test that embeds the test studio * chore: support HMR same way test-studio does * refactor: replace deprecated `empty()` with `EMPTY` * refactor: shorter `pnpm dev:next-studio` alias * chore: add `dev:turbo-studio` to test with turbopack * chore: remove unused * chore(deps): dedupe pnpm-lock.yaml (#6493) Co-authored-by: github-merge-queue[bot] <118344674+github-merge-queue[bot]@users.noreply.github.com> * chore(deps): update dependency @sanity/pkg-utils to v6.8.7 (#6496) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency @sanity/logos to v2.1.11 (#6498) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency @sanity/react-loader to v1.9.15 (#6499) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @sanity/visual-editing to v1.8.16 (#6500) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @sanity/presentation to v1.12.10 (#6501) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(core): implement presence cursors (#6081) * feat(portable-text-editor): improve range decorations perf by comparing prev values * test(portable-text-editor): add tests for range decorations rendering * fixup! feat(portable-text-editor): improve range decorations perf by comparing prev values * test(portable-text-editor): improve some minor test things * fix(core): update z-index on PTE activate overlay * feat(core): extend presence data model with `selection` * feat(structure): include `selection` in presence data * feat(core): implement presence cursors in PTE * test(core): add presence cursor workshop story * refactor(core): use `getTheme_v2` to access theme values * fix(core): introduce `OnPathFocusPayload` to improve typing * fix(form/inputs): perf optimization for PT-input decorators * refactor(form/inputs): also display user presence when user is selecting a range, but only the focus point of it * fix(core): render presence cursors inline instead of in a portal * fix(core): broken workshop story * feat(core): reset presence selection on blur in PTE * fix(structure): add accidentially removed setFocusPath (DocumentPaneProvider) This seems to have been lost in a rebase. * fix(core): use `useFormFieldPresence` in `usePresenceCursorDecorations` * fix(core): set `focusPath` when receiving a mutation event if there are pending patches * fix(form/inputs): break don't return * fix(form/inputs): remove ref that should not be set here This ref is supposed to be set elsewhere (on the PTE Editable component) See eca960e * fix(form/inputs): sort hook deps list * fix(form/inputs): reconcile presence decorations for PT-Input Make sure these objects stays as stable as possible in order to not redraw any range decorations unnecessary. * fix(form/inputs): return early if focusPath is already selected in PT-Input * refactor(form/inputs): throttle reporting of focusPath and presence updates for PT-input * fix(core): import of `FormNodePresence` * fix(form/inputs): remove lastActive as dep for PT-presence range decorations uniqueness We are not using this value anyway, and it complicates the reconciliation of the presence decorators * test(core): add presence cursor workshop story * fix(core): remove unnecessary z-index in PTE activate overlay * fix(core): prevent presence cursor user name from being selected * fix(form/inputs): fix issue where perf opt on focusPath tracking broke tests This perf opt. broke some tests. It's not clear if it is a problem with the test or the func. so restoring the old behaviour for now. * test(core): update snapshots in `Studio.test` * refactor(core): move presence decorations according to user edits Use a own state for this. * refactor(core/form): remove complexity from PortableTextInput Handle debouncing in the DocumentProvider instead. Setting focusPath must be synchronous * refactor(structure): announce presence throttled When we introduced presence in the PortableTextInput, we risk calling the presence updates very often. There should be no reason for not doing this throttled, as long as we have leading true. * refactor(core): clean up presence cursors code + add comments --------- Co-authored-by: Per-Kristian Nordnes <per.kristian.nordnes@gmail.com> * fix(deps): Update react monorepo (#6502) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lint): add certain unicorn eslint rules (#6352) * chore(lint): add certain unicorn eslint rules * chore: fix lint errors * test: increase timeout for cross-dataset reference test * chore: fix incorrect path used in workshop story * chore(deps): dedupe pnpm-lock.yaml (#6506) Co-authored-by: rexxars <48200+rexxars@users.noreply.github.com> * fix(structure): uncaught error while swapping images in array in PTE (#6399) * chore(test-studio): add schema for fix * fix(structure): console error for when selection is zero * chore(test-studio): update test schema * chore(core): remove try catch * test(pte): add test for usecase * chore(sanity): remove ? since it will always be defined Co-authored-by: Pedro Bonamin <46196328+pedrobonamin@users.noreply.github.com> * chore(test): fix test file to have .spec. --------- Co-authored-by: Pedro Bonamin <46196328+pedrobonamin@users.noreply.github.com> * chore(deps): update dependency @types/react to v18.3.1 (#6507) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * v3.39.1 * chore(deps): dedupe pnpm-lock.yaml (#6463) Co-authored-by: cngonzalez <3969996+cngonzalez@users.noreply.github.com> * chore(deps): update dependency @sanity/pkg-utils to v6.8.4 (#6460) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: add perf runner to workspace (#6427) * chore(deps): update dependency @sanity/tsdoc to v1.0.39 (#6464) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: upgrade groq-js (#6474) * chore: upgrade groq-js * chore: always bump groq-js * chore(deps): dedupe pnpm-lock.yaml (#6476) Co-authored-by: github-merge-queue[bot] <118344674+github-merge-queue[bot]@users.noreply.github.com> * chore(deps): update dependency @sanity/visual-editing to v1.8.15 (#6465) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency @sanity/react-loader to v1.9.14 (#6466) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency i18next to v23.11.2 (#6468) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency zod to v3.23.4 (#6470) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency next to v14.2.2 (#6469) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency react-focus-lock to v2.12.1 (#6471) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @sanity/pkg-utils to v6.8.6 (#6482) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update react monorepo (#6484) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @sanity/tsdoc to v1.0.40 (#6483) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @sanity/presentation to v1.12.8 (#6485) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update react monorepo to ^18.3.0 (#6490) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: setup next test that embeds the test studio (#6487) * chore: setup next test that embeds the test studio * chore: support HMR same way test-studio does * refactor: replace deprecated `empty()` with `EMPTY` * refactor: shorter `pnpm dev:next-studio` alias * chore: add `dev:turbo-studio` to test with turbopack * chore: remove unused * chore(deps): dedupe pnpm-lock.yaml (#6493) Co-authored-by: github-merge-queue[bot] <118344674+github-merge-queue[bot]@users.noreply.github.com> * chore(deps): update dependency @sanity/pkg-utils to v6.8.7 (#6496) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency @sanity/logos to v2.1.11 (#6498) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(lockfile): update dependency @sanity/react-loader to v1.9.15 (#6499) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @sanity/visual-editing to v1.8.16 (#6500) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @sanity/presentation to v1.12.10 (#6501) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(core): implement presence cursors (#6081) * feat(portable-text-editor): improve range decorations perf by comparing prev values * test(portable-text-editor): add tests for range decorations rendering * fixup! feat(portable-text-editor): improve range decorations perf by comparing prev values * test(portable-text-editor): improve some minor test things * fix(core): update z-index on PTE activate overlay * feat(core): extend presence data model with `selection` * feat(structure): include `selection` in presence data * feat(core): implement presence cursors in PTE * test(core): add presence cursor workshop story * refactor(core): use `getTheme_v2` to access theme values * fix(core): introduce `OnPathFocusPayload` to improve typing * fix(form/inputs): perf optimization for PT-input decorators * refactor(form/inputs): also display user presence when user is selecting a range, but only the focus point of it * fix(core): render presence cursors inline instead of in a portal * fix(core): broken workshop story * feat(core): reset presence selection on blur in PTE * fix(structure): add accidentially removed setFocusPath (DocumentPaneProvider) This seems to have been lost in a rebase. * fix(core): use `useFormFieldPresence` in `usePresenceCursorDecorations` * fix(core): set `focusPath` when receiving a mutation event if there are pending patches * fix(form/inputs): break don't return * fix(form/inputs): remove ref that should not be set here This ref is supposed to be set elsewhere (on the PTE Editable component) See eca960e * fix(form/inputs): sort hook deps list * fix(form/inputs): reconcile presence decorations for PT-Input Make sure these objects stays as stable as possible in order to not redraw any range decorations unnecessary. * fix(form/inputs): return early if focusPath is already selected in PT-Input * refactor(form/inputs): throttle reporting of focusPath and presence updates for PT-input * fix(core): import of `FormNodePresence` * fix(form/inputs): remove lastActive as dep for PT-presence range decorations uniqueness We are not using this value anyway, and it complicates the reconciliation of the presence decorators * test(core): add presence cursor workshop story * fix(core): remove unnecessary z-index in PTE activate overlay * fix(core): prevent presence cursor user name from being selected * fix(form/inputs): fix issue where perf opt on focusPath tracking broke tests This perf opt. broke some tests. It's not clear if it is a problem with the test or the func. so restoring the old behaviour for now. * test(core): update snapshots in `Studio.test` * refactor(core): move presence decorations according to user edits Use a own state for this. * refactor(core/form): remove complexity from PortableTextInput Handle debouncing in the DocumentProvider instead. Setting focusPath must be synchronous * refactor(structure): announce presence throttled When we introduced presence in the PortableTextInput, we risk calling the presence updates very often. There should be no reason for not doing this throttled, as long as we have leading true. * refactor(core): clean up presence cursors code + add comments --------- Co-authored-by: Per-Kristian Nordnes <per.kristian.nordnes@gmail.com> * fix(deps): Update react monorepo (#6502) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: fix incorrect path used in workshop story * chore(deps): dedupe pnpm-lock.yaml (#6506) Co-authored-by: rexxars <48200+rexxars@users.noreply.github.com> * chore(deps): update dependency @types/react to v18.3.1 (#6507) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --------- Co-authored-by: ecospark[bot] <128108030+ecospark[bot]@users.noreply.github.com> Co-authored-by: cngonzalez <3969996+cngonzalez@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Sindre Gulseth <sgulseth@gmail.com> Co-authored-by: Bjørge Næss <bjoerge@gmail.com> Co-authored-by: github-merge-queue[bot] <118344674+github-merge-queue[bot]@users.noreply.github.com> Co-authored-by: Cody Olsen <81981+stipsan@users.noreply.github.com> Co-authored-by: Rostislav Melkumyan <hello@rosti.no> Co-authored-by: Espen Hovlandsdal <espen@hovlandsdal.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Herman Wikner <wiknerherman@gmail.com> Co-authored-by: Per-Kristian Nordnes <per.kristian.nordnes@gmail.com> Co-authored-by: rexxars <48200+rexxars@users.noreply.github.com> Co-authored-by: RitaDias <rita@sanity.io> Co-authored-by: Pedro Bonamin <46196328+pedrobonamin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
statusButtongenericaria-labelwas not specific enough in all usages. This PR makesaria-labela required prop onstatusButtonand defines all current usages a valueWhat to review
The only ambiguous usage is in
packages/sanity/src/structure/components/pane/PaneHeaderActionButton.tsxwhere the fallback has been the original label used instatusButtonTesting
Notes for release
Fixes ambiguous aria-labels on some Status buttons