-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): avoid attribute names being scanned as symbols. Fixes #5673 #6624
Changes from 3 commits
680d428
002f929
012f851
8ca661d
954698e
48de5cf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -183,6 +183,10 @@ const cases = { | |
}, | ||
], | ||
}, | ||
trueOrFalseField: { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we add a test that fails if this name is just There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added explicit tests for parsing symbols versus attributes/identifiers |
||
type: 'attribute', | ||
name: 'trueOrFalseField', | ||
}, | ||
} | ||
|
||
Object.keys(cases).forEach((path) => { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we know what the perf hit is on looking ahead on each match?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would only do this extra check when it encounters a symbol match which is all attribute-valid chars, meaning
"true"
and"false"