Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @sanity/bifur-client to ^0.4.0 #6645

Merged
merged 1 commit into from
May 24, 2024

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented May 13, 2024

Description

The new bifur client introduced a breaking change, where subscription based methods have to be called on the listen() method instead of on the request() method. This makes it more obvious that they're going to provide values over time and not a one-off response. Additionally, it allows reusing the same base method name for both subscriptions and one-off requests, eg authorize vs authorize_subscribe.

What to review

Presence still work as before.

Testing

Only a dependency upgrade, so should not be necessary.

Notes for release

None

@rexxars rexxars requested a review from a team as a code owner May 13, 2024 23:56
@rexxars rexxars requested a review from binoy14 May 13, 2024 23:56
Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 8:27pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 8:27pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 8:27pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 8:27pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 8:27pm

Copy link

socket-security bot commented May 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@sanity/bifur-client@0.4.0 None 0 52.8 kB rexxars

🚮 Removed packages: npm/@sanity/bifur-client@0.3.1

View full report↗︎

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented May 14, 2024

Component Testing Report Updated May 24, 2024 8:30 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 14s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ❌ Failed (Inspect) 1m 8s 17 0 1
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 6s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 32s 12 0 0

binoy14
binoy14 previously approved these changes May 14, 2024
@ricokahler ricokahler dismissed binoy14’s stale review May 14, 2024 15:52

The merge-base changed after approval.

@rexxars rexxars requested a review from a team as a code owner May 14, 2024 15:52
@rexxars rexxars requested review from sjelfull and removed request for a team May 14, 2024 15:52
@ricokahler ricokahler requested a review from a team as a code owner May 15, 2024 21:56
@rexxars rexxars added this pull request to the merge queue May 24, 2024
Merged via the queue into next with commit a79ea02 May 24, 2024
42 checks passed
@rexxars rexxars deleted the chore/upgrade-bifur-client branch May 24, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants