test(sanity): update hydrate test #6821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
stipsan
approved these changes
May 31, 2024
There was a problem hiding this comment.
I slept on it and I think the reason I used the snapshots when I wrote these tests originally was to aid debugging: "what does it render?"
Since they keep failing the tests when class strings change I think they do more harm than good so it makes sense to get rid of them.
The hydrateRoot test is very useful though as it would catch issues that would otherwise only appear for Studios that are embedded in Next or Remix apps 🙌
|
Component Testing Report Updated May 31, 2024 7:01 AM (UTC)
|
RitaDias
added a commit
that referenced
this pull request
May 31, 2024
binoy14
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the studio.test.tsx after having it consistently failing on a separate PR and updating the snapshot not fixing it (the classes were consistently changing)
Spoke with Cody and in that case in particular it was related to the style components and the order with which the components that use them are called.
The snapshot test was brittle since it was screaming that something was wrong when it reality it could just be different (and that was the intended result). The following test was written with Cody to remain useful and to target hydration test but without having to rely on snapshots.
What to review
That the test makes sense and there isn't a better way of doing it.
Notes for release
N/A (let me know if this is something that we want to appear on the release notes I just don't think we need to)