Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move up call to PATCH metadata after bootstrapping template files #6828

Merged
merged 1 commit into from
Jun 3, 2024
Merged

feat: move up call to PATCH metadata after bootstrapping template files #6828

merged 1 commit into from
Jun 3, 2024

Conversation

svirs
Copy link
Contributor

@svirs svirs commented May 31, 2024

Description

Previously made api call is now moved up in case something else in the init flow does not let this call be made at the very end. This call is necessary to indicate that the bootstrapped files are now made local.

What to review

Project init flow should act the same, the call should occur after the studio files are created.

@svirs svirs requested a review from a team as a code owner May 31, 2024 13:34
@svirs svirs requested review from rexxars and removed request for a team May 31, 2024 13:34
@vercel Vercel
Copy link

vercel bot commented May 31, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 6:45pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 6:45pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 6:45pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 6:45pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 6:45pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jun 2, 2024 6:45pm

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 31, 2024 •
edited

Component Testing Report Updated Jun 2, 2024 6:50 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 37s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 32s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 37s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 16s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 4s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 21s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 30s 12 0 0

@svirs svirs requested review from a team and removed request for a team May 31, 2024 13:45
rexxars
rexxars previously approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@svirs svirs enabled auto-merge May 31, 2024 20:12
@svirs svirs disabled auto-merge May 31, 2024 20:13
@svirs svirs enabled auto-merge June 2, 2024 18:40
@svirs svirs disabled auto-merge June 2, 2024 18:41
@svirs svirs requested a review from rexxars June 3, 2024 05:06
@svirs svirs merged commit 7d47a51 into next Jun 3, 2024
42 of 43 checks passed
@svirs svirs deleted the gro-2098 branch June 3, 2024 16:51
@leocabrallce leocabrallce mentioned this pull request Jun 27, 2024
Open
@leocabrallce leocabrallce mentioned this pull request Jul 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rexxars rexxars rexxars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svirs @rexxars