Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(structure): sheet list table columns selectors style edx-1435 #6839

Merged
merged 9 commits into from
Jun 4, 2024
Merged

feat(structure): sheet list table columns selectors style edx-1435 #6839

merged 9 commits into from
Jun 4, 2024

Conversation

jordanl17
Copy link
Member

@jordanl17 jordanl17 commented Jun 3, 2024 •
edited
Loading

Description

What to review

  • New Icon used for Sheet List view in doc list menu
Screenshot 2024-06-03 at 18 28 34
  • New styling for columns control conforming to Figma designs
Screenshot 2024-06-03 at 18 27 09
  • Styles for the headers conforming to Figma designs
Screenshot 2024-06-03 at 18 28 10
  • Support for sticky columns

Testing

There are very few functionality changes here. Tests added for new functionality in Header's menu for removing field from view

Notes for release

Nothing relevant - this feature is not currently client visible

@vercel Vercel
Copy link

vercel bot commented Jun 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 9:40am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 9:40am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 9:40am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 9:40am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 9:40am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 9:40am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024 •
edited
Loading

Component Testing Report Updated Jun 4, 2024 9:42 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 32s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 37s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 21s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 21s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 31s 12 0 0

@jordanl17 jordanl17 marked this pull request as ready for review June 3, 2024 18:34
@jordanl17 jordanl17 requested review from a team as code owners June 3, 2024 18:34
@jordanl17 jordanl17 requested review from sjelfull, binoy14 and pedrobonamin and removed request for a team June 3, 2024 18:34
pedrobonamin
pedrobonamin approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@pedrobonamin pedrobonamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks @jordanl17 !

@pedrobonamin pedrobonamin changed the title Edx 1435 header col style feat(structure): sheet list table header col style edx-1435 Jun 4, 2024
@pedrobonamin pedrobonamin changed the title feat(structure): sheet list table header col style edx-1435 feat(structure): sheet list table columns selectors style edx-1435 Jun 4, 2024
@jordanl17 jordanl17 added this pull request to the merge queue Jun 4, 2024
Merged via the queue into next with commit 6d53c4c Jun 4, 2024
44 checks passed
@jordanl17 jordanl17 deleted the EDX-1435-header-col-style branch June 4, 2024 10:35
@leocabrallce leocabrallce mentioned this pull request Jun 27, 2024
Open
@leocabrallce leocabrallce mentioned this pull request Jul 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobonamin pedrobonamin pedrobonamin approved these changes

@sjelfull sjelfull Awaiting requested review from sjelfull sjelfull was automatically assigned from sanity-io/studio-ex

@binoy14 binoy14 Awaiting requested review from binoy14 binoy14 is a code owner automatically assigned from sanity-io/studio-dx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordanl17 @pedrobonamin