refactor(core): rename InsertMenu->InsertMenuGroups #6845
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I want to introduce a new
InsertMenu
abstraction and this component's name is conflicting with that. At the same time, I think this component is wrongly named. It does not return an "insert menu", it returns two menu groups that can be used as sub menus in an existing menul.What to review
Is this new name good?
Testing
No testing needed.
Notes for release