Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): rename InsertMenu->InsertMenuGroups #6845

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

christianhg
Copy link
Contributor

Description

I want to introduce a new InsertMenu abstraction and this component's name is conflicting with that. At the same time, I think this component is wrongly named. It does not return an "insert menu", it returns two menu groups that can be used as sub menus in an existing menul.

What to review

Is this new name good?

Testing

No testing needed.

Notes for release

@christianhg christianhg requested a review from a team as a code owner June 4, 2024 11:04
@christianhg christianhg requested review from cngonzalez and removed request for a team June 4, 2024 11:04
Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 11:06am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 11:06am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 11:06am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 11:06am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 11:06am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jun 4, 2024 11:06am

Copy link
Contributor

github-actions bot commented Jun 4, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Component Testing Report Updated Jun 4, 2024 11:12 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 21s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 2s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 21s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 30s 12 0 0

@stipsan stipsan added this pull request to the merge queue Jun 4, 2024
Merged via the queue into next with commit e1fd6bf Jun 4, 2024
45 checks passed
@stipsan stipsan deleted the chore-rename-insert-menu branch June 4, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants