Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(structure): fixing issue with shift mutli select of documents #6857

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

jordanl17
Copy link
Member

Description

A regression came in around shift-selecting documents and selecting all in between. This was because the IDs of rows changed from being the row index to the document ID.

What to review

Testing

Updates to the Select tests also

Notes for release

Nothing to note - this feature is not customer facing

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 1:36pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 1:36pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 1:36pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 1:36pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 1:36pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jun 5, 2024 1:36pm

Copy link
Contributor

github-actions bot commented Jun 5, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Component Testing Report Updated Jun 5, 2024 1:44 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 17s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 4s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 21s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 29s 12 0 0

@jordanl17 jordanl17 marked this pull request as ready for review June 5, 2024 13:45
@jordanl17 jordanl17 requested a review from a team as a code owner June 5, 2024 13:45
@jordanl17 jordanl17 requested review from RitaDias and pedrobonamin and removed request for a team June 5, 2024 13:45
@jordanl17 jordanl17 added this pull request to the merge queue Jun 5, 2024
Merged via the queue into next with commit 15861f4 Jun 5, 2024
44 checks passed
@jordanl17 jordanl17 deleted the edx-1448-fix-multi-select branch June 5, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants