fix(core): chunk user loading into batches of max 400 items #6858
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a case where passing a large number of users to retrieve from the user store would cause too large of a request to be sent. This chunks the number of users to fetch into batches of 400.
What to review
Testing
Added tests for the user store in general, there was previously only tests for the 403 case - now it should have the majority of the functionality covered (some missing tests for the
getUser
function, but it callsgetUsers
internally - can add those later)Notes for release