feat: notify AUS studio users of new studio versions #6893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
cngonzalez
force-pushed
the
sdx-1244/notify-user-of-new-version
branch
from
25c7957
to
26d1ba7
Compare
|
No changes to documentation |
|
Component Testing Report Updated Jun 18, 2024 3:10 PM (UTC)
|
cngonzalez
force-pushed
the
sdx-1244/notify-user-of-new-version
branch
from
26d1ba7
to
d831893
Compare
cngonzalez
force-pushed
the
sdx-1244/notify-user-of-new-version
branch
from
d831893
to
5b46348
Compare
cngonzalez
requested review from
juice49,
rexxars and
binoy14
and removed request for
a team
binoy14
reviewed
Jun 12, 2024
|
|
||
| const MODULES_URL_VERSION = 'v1' | ||
|
|
||
| const MODULES_URL = `https://sanity-cdn.com/${MODULES_URL_VERSION}/modules/` |
There was a problem hiding this comment.
Could we somehow share this with logic in CLI here? https://github.com/sanity-io/sanity/blob/next/packages/sanity/src/_internal/cli/util/getAutoUpdatesImportMap.ts#L11
Maybe we just need to lift this out in some constant?
There was a problem hiding this comment.
Hmm, yeah. Do we have precedent for sharing something like this between CLI and studio? Otherwise, happy to copy.
There was a problem hiding this comment.
I am not sure if there is, might be worth asking internally but for now okay with copy pasting as well
packages/sanity/src/core/studio/packageVersionStatus/PackageVersionStatusProvider.tsx
Show resolved
Hide resolved
packages/sanity/src/core/studio/packageVersionStatus/PackageVersionStatusProvider.tsx
Outdated
Show resolved
Hide resolved
ricokahler
previously approved these changes
Jun 18, 2024
runeb
reviewed
Jun 18, 2024
Co-authored-by: Rune Botten <rbotten@gmail.com>
Co-authored-by: Rune Botten <rbotten@gmail.com>
Co-authored-by: Rune Botten <rbotten@gmail.com>
ricokahler
previously approved these changes
Jun 18, 2024
ricokahler
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As we move to certain packages being able to auto-update, we want end-users of the studio to know when to refresh their browsers and work with the most up-to-date packages.
This PR adds a Provider that will:
What to review
Unfortunately I think the reviewer ought to pull this down and review manually -- see below for why (because of limited ability to test).
Testing
I've added a few e2e tests. I'm not testing if the reload button actually reloads the page; I couldn't find an easy way for Playwright to listen to that event.