Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression causing ESM build errors #6909

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: regression causing ESM build errors #6909

merged 1 commit into from
Jun 12, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Jun 12, 2024

Description

Fixes regression caused by #6867

What to review

Existing tests are enough.

Testing

In the future please don't ignore the testExports check 🙌

Notes for release

N/A as AFAIK the regression caused by #6867 isn't published yet

@stipsan stipsan requested a review from a team as a code owner June 12, 2024 15:09
@stipsan stipsan requested review from cngonzalez and removed request for a team June 12, 2024 15:09
Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 3:10pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 3:10pm
test-compiled-studio 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 3:10pm
test-next-studio 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 3:10pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 3:10pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jun 12, 2024 3:10pm

Copy link
Contributor

No changes to documentation

@stipsan stipsan added this pull request to the merge queue Jun 12, 2024
Merged via the queue into next with commit 0b92a8e Jun 12, 2024
33 checks passed
@stipsan stipsan deleted the fix-ESM-build branch June 12, 2024 15:10
Copy link
Contributor

Component Testing Report Updated Jun 12, 2024 3:20 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 59s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 17s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 4s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 34s 11 0 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants