-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): fix dragging existing blocks in pte #6867
Merged
Merged
+327
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
Component Testing Report Updated Jun 12, 2024 12:59 PM (UTC)
|
sjelfull
force-pushed
the
fix/edx-1388-dragging-pte-blocks
branch
from
June 11, 2024 16:29
88299f3
to
53b43cf
Compare
sjelfull
force-pushed
the
fix/edx-1388-dragging-pte-blocks
branch
from
June 12, 2024 12:00
4286aeb
to
a537ad9
Compare
skogsmaskin
reviewed
Jun 12, 2024
packages/sanity/src/core/form/inputs/PortableText/Compositor.tsx
Outdated
Show resolved
Hide resolved
skogsmaskin
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to have this fixed. Thanks @sjelfull 👍
sjelfull
force-pushed
the
fix/edx-1388-dragging-pte-blocks
branch
from
June 12, 2024 12:48
9804ce2
to
575291f
Compare
Signed-off-by: Fred Carlsen <fred@sjelfull.no>
sjelfull
force-pushed
the
fix/edx-1388-dragging-pte-blocks
branch
from
June 12, 2024 12:48
575291f
to
2b0526f
Compare
This was referenced Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue preventing blocks in the PTE from being re-arranged after we added support for drag-n-drop of images/files to the PTE in #6534. Fixes #6626.
It also fixes some adjacent issues:
What to review
Testing
Playwright tests for this has been added.
Notes for release