Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix dragging existing blocks in pte #6867

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

sjelfull
Copy link
Member

@sjelfull sjelfull commented Jun 6, 2024

Description

This fixes an issue preventing blocks in the PTE from being re-arranged after we added support for drag-n-drop of images/files to the PTE in #6534. Fixes #6626.

It also fixes some adjacent issues:

  • Styling of info/error overlay when dragging files was not styled correctly in fullscreen mode (fixes EDX-1408, fixes EDX-1405)
  • Pasting from locally installed Word would insert an image version of the text being pasted instead of the actual text (fixes CRX-737)

What to review

  • That the logic change makes sense
  • That dragging PTE blocks works without showing any error messages
  • That both drag-n-drop and pasting of images and files works
  • That pasting from from locally installed Word sinsert the actual text instead of an image version

Testing

Playwright tests for this has been added.

Notes for release

  • Fixes an issue when dragging PTE blocks
  • Fixes an visual regression in PTE fullscreen mode where the Drop to upload n files message would be position incorrectly
  • Fixes an regression where pasting from Word would insert an image version of the text being pasted instead of the actual text

@sjelfull sjelfull requested a review from skogsmaskin June 6, 2024 14:00
@sjelfull sjelfull self-assigned this Jun 6, 2024
@sjelfull sjelfull requested a review from a team June 6, 2024 14:00
@sjelfull sjelfull requested a review from a team as a code owner June 6, 2024 14:00
@sjelfull sjelfull requested review from binoy14 and removed request for a team June 6, 2024 14:00
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 0:55am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 0:55am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 0:55am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 0:55am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 0:55am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 0:55am

@sjelfull sjelfull requested review from ninaandal and a team June 6, 2024 14:01
Copy link
Contributor

github-actions bot commented Jun 6, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Component Testing Report Updated Jun 12, 2024 12:59 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 37s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 32s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 52s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 17s 20 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 5s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 30s 12 0 0

@sjelfull sjelfull force-pushed the fix/edx-1388-dragging-pte-blocks branch from 88299f3 to 53b43cf Compare June 11, 2024 16:29
@sjelfull sjelfull force-pushed the fix/edx-1388-dragging-pte-blocks branch from 4286aeb to a537ad9 Compare June 12, 2024 12:00
@skogsmaskin skogsmaskin self-requested a review June 12, 2024 12:47
Copy link
Member

@skogsmaskin skogsmaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this fixed. Thanks @sjelfull 👍

@sjelfull sjelfull force-pushed the fix/edx-1388-dragging-pte-blocks branch from 9804ce2 to 575291f Compare June 12, 2024 12:48
Signed-off-by: Fred Carlsen <fred@sjelfull.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On >3.41.0 dragging blocks in PTE gives "Can't upload this file here" error
2 participants