-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(router): pass options on scoped router navigation #6923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
Component Testing Report Updated Jun 13, 2024 9:34 AM (UTC)
|
bjoerge
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Definitely looks like an oversight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scoped routers implement their own
navigate
function which wraps that of the parent router and calls it with some new resolved state.Currently this wrapper function does not pass an options param to the parent function call. As far as I can tell this means scoped routers can only push, not replace history state. I suspect this is an oversight as for example the
PaneRouter
attempts to replace using an options param.Similarly, in the Presentation tool, we can't currently replace history state as we implement our own scoped router (
PresentationPaneRouterProvider
), I believe this PR would fix that issue for us.What to review
Before this PR:
You will navigate back to the deleted document. The code linked to above suggests this shouldn't be the case.
After this PR:
You will navigate back to the Structure tool root.
Testing
Notes for release
Pass navigation options when calling a scoped router's navigate function.