refactor(core): change revision history label from 'Version' to the more accurate 'Revision'

[bjoerge]

Description

This makes our labeling of revision to be more consistent. We are calling it revision in someplaces but not everywhere. Also updated the code to be more consistent too.

What to review

• Is the way I've deprecate the old i18n key ok?
• Would it be better to leave the key as-is and instead just change the label?

Testing

Don't think it makes all that much sense to add automated testing for this one

Notes for release

n/a - should just make the studio terminology more consistent.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 18, 2024 1:04pm
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 18, 2024 1:04pm
test-compiled-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 18, 2024 1:04pm
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 18, 2024 1:04pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 18, 2024 1:04pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Jun 18, 2024 1:04pm

[github-actions]

No changes to documentation

[github-actions]

Component Testing Report Updated Jun 18, 2024 1:10 PM (UTC)

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	43s	14	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	7s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	27s	6	0	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	32s	11	7	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	14s	6	0	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	8s	3	0	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	44s	2	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	36s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 14s	20	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 4s	18	0	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	7s	3	9	0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	20s	9	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	15s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	29s	12	0	0

[binoy14]

defer to @rexxars on deprecating i18n keys. Not sure we have a process

[bjoerge]

There's no clear process, but we can make this an opportunity to establish one?

This was a fair amount of OCD-induced change 😅, but I still feel the change it's justified by the likelyhood of existing language bundles already having translated "version" instead of "revision" (for example, the norwegian bundle is currently using "Siste versjon" here, when it should be "Siste revisjon"), and this change will give downstream locale implementors a chance to notice the change.

I've pushed some added clarity in the comments in 4864109 based on input from @rexxars.

[binoy14]

understood, I am okay with the change just wanted to call it out

[binoy14]

@bjoerge I don't see anywhere in the code timeline.latest-revision key being used. Is that expected?

[bjoerge]

🤦🏼 forgot to change it in code, fixed in 66f81e4. Thanks for catching!

[binoy14]

makes sense to me, thanks!