Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove react hooks linter suppressions in PT hooks #7222

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Jul 22, 2024

Description

Removes linter suppressions by refactoring the hook to reference all the dependencies it has, so it's no longer implicit.

What to review

Does it make sense?

Testing

Existing tests are enough.

Notes for release

N/A

@stipsan stipsan requested review from a team as code owners July 22, 2024 12:51
@stipsan stipsan requested review from hermanwikner and bjoerge and removed request for a team July 22, 2024 12:51
Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 7:50pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 7:50pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 7:50pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 7:50pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 7:50pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 7:50pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Jul 22, 2024

Component Testing Report Updated Jul 31, 2024 7:52 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 42s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 36s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 45s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 13s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 25s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 1m 24s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 1m 46s 30 0 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 20s 3 0 0

@bjoerge bjoerge removed their request for review July 23, 2024 12:07
@bjoerge
Copy link
Member

bjoerge commented Jul 23, 2024

I'm afraid I don't have enough context to review this, so unassigning myself

@stipsan stipsan force-pushed the fix-SearchFilterAssetInput-react-linter-supressions branch from 08a24a4 to f77ff87 Compare July 31, 2024 19:08
@stipsan stipsan changed the base branch from fix-SearchFilterAssetInput-react-linter-supressions to next July 31, 2024 19:33
@stipsan stipsan force-pushed the fix-portable-text-hooks-linter-supressions branch from ccaa39a to 0d1c018 Compare July 31, 2024 19:33
Copy link
Contributor

@christianhg christianhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good and everything seems to work as before.

@stipsan stipsan added this pull request to the merge queue Aug 1, 2024
Merged via the queue into next with commit f5cac7b Aug 1, 2024
43 checks passed
@stipsan stipsan deleted the fix-portable-text-hooks-linter-supressions branch August 1, 2024 07:37
cngonzalez pushed a commit that referenced this pull request Aug 20, 2024
* chore(deps): bump react-compiler deps

* fix: remove react hooks linter suppressions in PT hooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants