-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove react hooks linter suppressions in PT hooks #7222
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
Component Testing Report Updated Jul 31, 2024 7:52 PM (UTC)
|
I'm afraid I don't have enough context to review this, so unassigning myself |
e53a6e9
to
1087f55
Compare
db0b6f4
to
94b9b2b
Compare
1087f55
to
05bc10b
Compare
94b9b2b
to
4b24355
Compare
05bc10b
to
08a24a4
Compare
4b24355
to
ccaa39a
Compare
08a24a4
to
f77ff87
Compare
ccaa39a
to
0d1c018
Compare
0d1c018
to
ed927e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good and everything seems to work as before.
* chore(deps): bump react-compiler deps * fix: remove react hooks linter suppressions in PT hooks
Description
Removes linter suppressions by refactoring the hook to reference all the dependencies it has, so it's no longer implicit.
What to review
Does it make sense?
Testing
Existing tests are enough.
Notes for release
N/A