chore(core): refactor useDocumentVersion to use ListenQuery #7241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
pedrobonamin
requested review from
juice49 and
RitaDias
and removed request for
a team
|
No changes to documentation |
jordanl17
reviewed
Jul 26, 2024
jordanl17
reviewed
Jul 26, 2024
Comment on lines
46
to
54
| const state = useMemo( | ||
| () => | ||
| versions | ||
| ? (versions | ||
| .map((r) => bundles?.find((b) => r._version && getBundleSlug(r._id) === b.slug)) | ||
| .filter(Boolean) as BundleDocument[]) | ||
| : null, | ||
| [versions, bundles], | ||
| ) |
There was a problem hiding this comment.
COULD:
just to improve readability with the find nested in the map, I feel this reads a little more clearly:
Suggested change
| const state = useMemo( | |
| () => | |
| versions | |
| ? (versions | |
| .map((r) => bundles?.find((b) => r._version && getBundleSlug(r._id) === b.slug)) | |
| .filter(Boolean) as BundleDocument[]) | |
| : null, | |
| [versions, bundles], | |
| ) | |
| const state = useMemo(() => { | |
| if (!versions) return null | |
| const validBundles = versions | |
| .map(({_id, _version}) => { | |
| if (!_version) return null | |
| const bundleSlug = getBundleSlug(_id) | |
| return bundles?.find((bundle) => bundle.slug === bundleSlug) || null | |
| }) | |
| .filter(Boolean) as BundleDocument[] | |
| return validBundles | |
| }, [versions, bundles]) |
There was a problem hiding this comment.
Good suggestion, applied, thanks!
jordanl17
approved these changes
Jul 26, 2024
bjoerge
pushed a commit
that referenced
this pull request
Jul 30, 2024
* chore(core): refactor useDocumentVersion to use ListenQuery * fix(core): update useDocumentVersions state
bjoerge
pushed a commit
that referenced
this pull request
Jul 30, 2024
* chore(core): refactor useDocumentVersion to use ListenQuery * fix(core): update useDocumentVersions state
bjoerge
pushed a commit
that referenced
this pull request
Aug 2, 2024
* chore(core): refactor useDocumentVersion to use ListenQuery * fix(core): update useDocumentVersions state
juice49
pushed a commit
that referenced
this pull request
Aug 4, 2024
* chore(core): refactor useDocumentVersion to use ListenQuery * fix(core): update useDocumentVersions state
juice49
pushed a commit
that referenced
this pull request
Aug 6, 2024
* chore(core): refactor useDocumentVersion to use ListenQuery * fix(core): update useDocumentVersions state
bjoerge
pushed a commit
that referenced
this pull request
Aug 7, 2024
* chore(core): refactor useDocumentVersion to use ListenQuery * fix(core): update useDocumentVersions state
bjoerge
pushed a commit
that referenced
this pull request
Aug 16, 2024
* chore(core): refactor useDocumentVersion to use ListenQuery * fix(core): update useDocumentVersions state
bjoerge
pushed a commit
that referenced
this pull request
Aug 20, 2024
* chore(core): refactor useDocumentVersion to use ListenQuery * fix(core): update useDocumentVersions state
bjoerge
pushed a commit
that referenced
this pull request
Aug 20, 2024
* chore(core): refactor useDocumentVersion to use ListenQuery * fix(core): update useDocumentVersions state
bjoerge
pushed a commit
that referenced
this pull request
Aug 20, 2024
* chore(core): refactor useDocumentVersion to use ListenQuery * fix(core): update useDocumentVersions state
RitaDias
pushed a commit
that referenced
this pull request
Aug 23, 2024
* chore(core): refactor useDocumentVersion to use ListenQuery * fix(core): update useDocumentVersions state
RitaDias
pushed a commit
that referenced
this pull request
Aug 26, 2024
* chore(core): refactor useDocumentVersion to use ListenQuery * fix(core): update useDocumentVersions state
juice49
pushed a commit
that referenced
this pull request
Sep 3, 2024
* chore(core): refactor useDocumentVersion to use ListenQuery * fix(core): update useDocumentVersions state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactor useDocumentVersion to use
ListenQueryobservable.What to review
Testing
Existing tests updated and new tests added.
Notes for release