onMaskComplete event #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponent needs to send out an event
|
@sanniassin, can you have a look at this PR? Thx in advance |
|
@sanniassin this PR will be merged to the project sometime in this life? |
|
@robinschuere @rodrigobacelli Sorry for delay. I won't add any features which can be easily implemented in higher order component to keep this project as simple as possible. That's why i won't merge this PR. |
|
the component that provides the functionality of masked input does not give a callback on filling in this very mask. Leaving the need to implement this basic function by the user every time is a decision above all praise, facepalm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have need for a specific behaviour for sending a component event whenever the mask length is filled in. By using the onChange event, the caret would always go to the end. This behaviour was counterproductive.
I added the onMaskComplete event for when this rule applies. => the event get's fired whenever the inputs length is equal to the mask length.