Using Middleware; redirect instead of throw exception

[Naoray]

Wouldn't it be nicer if we would use a redirect to a specifiable route instead of just calling abort(403). Or maybe make it optional?!

We could ad a config entry like

'middleware_handling' => 'abort',
'middleware_params' => '403',

and change abort(403) in Middleware to

call_user_func(config('laratrust.midleware_handling'), config('middleware_params));

=> just an idea!

[santigarcor]

Actually i think it's a good idea.

[Naoray]

I tried it with:

// config
'middleware_handling' => 'abort',
'middleware_params' => '403',


// middleware
if ($this->auth->guest() || !$request->user()->ability($roles, $permissions, [ 'validate_all' => $validateAll ]))
{
    return call_user_func(Config::get('laratrust.middleware_handling'), Config::get('laratrust.middleware_params'));
}

... it works, but there are some errors in the tests:

1) LaratrustAbilityTest::testHandle_IsGuestWithNoAbility_ShouldAbort403
Mockery\Exception\NoMatchingExpectationException: No matching handler found for Mockery_9__config::get('laratrust.middleware_handling'). Either the method was unexpected or its arguments matched no expected argument list for this method

But I did not figure out how to resolve it yet. Any idea?

[santigarcor]

@Naoray Indeed i'm working on it. I think the problem is the test.

[santigarcor]

Could you please try it out, i got it working in 556515a. remember to add the middleware_handling and middleware_params to your config/laratrus.php file

[Naoray]

you've had a typo in the middlewares... fixed it in #24 . It works perfectly, but the tests are still failing!! :/

[santigarcor]

@Naoray yeah i had the typo, maybe i did the typo in the tests too, i'm going to check it out

[santigarcor]

@Naoray Yeah the problem was that the typo was on the tests too. i'm solving it now.

Thank you! 👍

[Naoray]

@santigarcor got them! fixed in #25

[santigarcor]

@Naoray , Thanks but i already solved it with 934f260