Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions in Laratrust panel don't acknowledge teams #572

Open
sparxooo opened this issue Sep 30, 2022 · 4 comments
Open

Permissions in Laratrust panel don't acknowledge teams #572

sparxooo opened this issue Sep 30, 2022 · 4 comments

Comments

@sparxooo
Copy link

  • Laravel Version: 9.31
  • Laratrust Version: 7.1

Describe the bug
If you have teams enabled, the built-in Laratrust panel has no way of selecting a team for the permissions to apply to.

To Reproduce
Assign a permission to a user + team.

On the Roles & Permissions assignment page, edit the user.

The panel shows all permissions assigned to the user, regardless of team_id column, and when saving it will duplicate all permissions again to that user with a null team id.

What I expect to happen
I expect that if teams are enabled, that for each user you can select Global (null team id), or select per team to assign permissions.

Apologies if I have mis understood the working of this package, but I believe this is the correct behaviour (and the panel is wrong). I'd love to not have to recreate the wheel!

@aliahmad900
Copy link

Same problem ..

@santigarcor
Copy link
Owner

This is a limitation in the admin panel. It doesn't work with the teams feature

@sparxooo
Copy link
Author

sparxooo commented Feb 21, 2023

@santigarcor would it be a beneficial thing to 1) note that in the page, and 2) ensure that only permissions/roles without a team_id are edited with the editor? Unless of course perhaps there is a version in the making that can manage team_id's

@santigarcor
Copy link
Owner

  1. I agree with you
  2. It could be done, any PRs are more thsn welcome.
  3. There's not a version with that included (on the making) but PRs are welcomed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants