Rework telegram authorization to use a plug #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanIvanoff
force-pushed
the
rework-telegram-authorization
branch
from
c040197
to
eb3f328
Compare
IvanIvanoff
force-pushed
the
rework-telegram-authorization
branch
from
eb3f328
to
a19e9bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To configure the router with an env variable it must be available at build time and cannot be provided at boot time. So for this purposes the authorization is made in a separate plug that does not have the same issue.
This approach is much simpler than what we do for the key_secret_base - adding the arg to docker and inject it in the CI.