-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add multiple domain support #3
Conversation
- improved indentation and set hierarchy funcs. - removed anr filter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PoshAJ I made a few changes to the source code. Removed anr
filter too. Testing it on my side looks good, could you please test it on yours and let me know if it's working properly? If you have some tests groups and are willing to update the old screenshots feel free to do so. Thank you.
Confirmed changes work with multiple domains, will take updated screenshots for README.md. @santisq One thing of note is that now that it's cross domain, would we want to add that to the output? I.E DOMAIN\USER vice just USER. |
@PoshAJ Sounds good, you can add that change if you like then merge. I'll probably rewrite this function as a binary cmdlet later this week. The code is really old and needs improvement but definitely if you come up with more improvements make a new PR. I'm thinking I'll add a |
looking good. thank you for your contribution @PoshAJ |
Added support for situations with multiple domains such as children domains. This had the side effect of removing the requirement for the ActiveDirectory module.