New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeepOpen is of type "undefined" #95

Closed

michaelkoswara opened this issue May 11, 2020 · 1 comment

Labels

bug

michaelkoswara commented May 11, 2020

Hi there, I am currently using your component for a production app.

One new client requirement is to keep the dropdown open at all times.

But when i try and use the "keepOpen" property, TS keeps saying it's of type "undefined"

When it should be of type boolean ?

sanusart added the bug label

sanusart closed this as completed in

11dec26

Owner

sanusart commented May 11, 2020

Should be fixed in v4.4.1

sanusart added a commit that referenced this issue


          Merge branch 'master' into next

dccf439

* master: (27 commits)
  v4.7.0 See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
  FIX (searchFn)[#101] searchFn callback should only call once when typing in the search bar, #134, #133 (#136)
  4.6.1
  Revert "FIX (searchFn)[#101] searchFn callback should only call once when typing in the search bar (#131)" (#135)
  v4.6.0 See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
  FIX (searchFn)[#101] searchFn callback should only call once when typing in the search bar (#131)
  v4.5.2 See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
  FIX (style): Accepts a short color (#127)
  v4.5.1 See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
  FIX (duplicates)[#116]: more proper way to check dupes, closes #116
  FIX (duplicates): PR comments
  FIX (duplicates)[#116]: more proper way to check dupes, closes #116
  bump version
  v4.5.0 See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
  FIX (input) [#114]: fix chars truncated, closes #114
  v4.4.2 See changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md
  FIX (box-model): add box-sizing border-box, closes #94 (#104)
  Bump websocket-extensions from 0.1.3 to 0.1.4 (#102)
  DOCS (example): add import to example, thanks to @karland, closes #93
  CHORE (types): fix keepOpen type | closes #95 (#96)
  ...

# Conflicts:
#	__tests__/__snapshots__/index.spec.js.snap
#	__tests__/components/__snapshots__/DropdownHandle.spec.js.snap
#	package-lock.json
#	src/components/DropdownHandle.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment