Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE (select some): extend inner method 'selectAll' to accept parameter #58

Merged
merged 2 commits into from
Dec 15, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
### v3.8.0
* FEATURE (select some): extend inner method 'selectAll' to accept parameter of list of items to select ref #57 [View](https://github.com/sanusart/react-dropdown-select/commit/ec36702adb66c3af552d9acc96b381ca228949ea)

### v3.7.0
* Corrected onChange callback in Select component (#56) [View](https://github.com/sanusart/react-dropdown-select/commit/86c716ab6f47882755024d436136281f2ed79f97)
* build [View](https://github.com/sanusart/react-dropdown-select/commit/0a90bf8cb28b711009cd2afa504022ecf4f8042a)
Expand Down
2 changes: 1 addition & 1 deletion dist/react-dropdown-select.js

Large diffs are not rendered by default.

11 changes: 10 additions & 1 deletion docs/src/examples/CustomContentAndDropdown.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,16 @@ export class CustomContentAndDropdown extends React.Component {
Clear all
</Button>
) : (
<Button onClick={methods.selectAll}>Select all</Button>
<React.Fragment>
<Button onClick={() => methods.selectAll(
[
props.options[0],
props.options[1],
props.options[3]
]
)}>Select 1st, 2nd and 4th</Button>
<Button onClick={methods.selectAll}>Select all</Button>
</React.Fragment>
)}
</Buttons>
<input
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/methods.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ title: 'methods'
| getInputSize() | - | number | input character count |
| toggleSelectAll() | - | undefined | |
| clearAll() | - | undefined | |
| selectAll() | - | undefined | will select all values except disabled |
| selectAll([]) | - | undefined | will select all values except disabled or a list of values provided as first parameter |
| isSelected(item) | **item**: object | boolean | |
| searchResults() | - | array | returns array of items matching `/item.label/i` regex, if `searchBy` prop is used - matches against it's value |
| selectRef() | - | DOM node | returns DOM element of &lt;Select/&gt; |
Expand Down
2 changes: 1 addition & 1 deletion lib/index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-dropdown-select",
"version": "3.7.0",
"version": "3.8.0",
"description": "Customizable dropdown select for react",
"main": "dist/react-dropdown-select.js",
"module": "lib/index.js",
Expand All @@ -14,9 +14,9 @@
"test": "jest --bail && npm run prepublishOnly && bundlesize",
"test:watch": "jest --bail --watch && npm run prepublishOnly && bundlesize",
"coveralls": "jest --coverage && cat ./coverage/lcov.info | coveralls",
"build": "webpack",
"build": "webpack && npm run transpile",
"transpile": "babel src -d lib",
"prepublishOnly": "npm run build && npm run transpile",
"prepublishOnly": "npm run build",
"version": "replace \"vPLACEHOLDER\" \"v$npm_package_version\" ./CHANGELOG.md && git add .",
"preversion": "sh change-log-builder.sh",
"release:patch": "npm version patch -m \"v%s \nSee changelog: https://github.com/sanusart/react-dropdown-select/blob/master/CHANGELOG.md\"",
Expand Down
10 changes: 6 additions & 4 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -285,11 +285,13 @@ export class Select extends Component {
});
};

selectAll = () => {
selectAll = (valuesList=[]) => {
this.props.onSelectAll();
return this.setState({
values: this.props.options.filter((option) => !option.disabled)
});
const values = valuesList.length > 0
? valuesList
: this.props.options.filter((option) => !option.disabled);

this.setState({ values });
};

isSelected = (option) =>
Expand Down
2 changes: 1 addition & 1 deletion types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface IMethods {
getInputSize: () => number;
toggleSelectAll: () => void;
clearAll: () => void;
selectAll: () => void;
selectAll: (items?: IItemRenderer['item'][]) => void;
searchResults: () => void;
getSelectRef: () => React.RefObject;
isSelected: (item: IItemRenderer['item']) => boolean;
Expand Down