Fix ovs connectivity issues after unclean reboot #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open vSwitch by default sets the datapath-id based on the MAC address of the bridges. If the underlying interfaces share the same MAC address (i.e. when using eth0 for br-fixed and eth0.300 for br-public) we will endup with duplicate datapath-ids, which break neutron-openvswitch-agent. https://bugzilla.suse.com/show_bug.cgi?id=1022074 (cherry picked from commit eface11)
During a clean shutdown wicked will delete any ovs bridges that it feels responsible for. This means that any customer settings on tha brigde will get lost and need to be restored. As we set a custom datapath_id for our bridge to prevent bsc#1022074. We need to restore that setting when the bridge is recreated during startup. Normally chef-client would do that as part of crowbar_join, but we also need it to happen when the admin server is down for some reason. OTOH, when the node is shutdown uncleanly (e.g. during a fencing operation) the ovs bridge will not get deleted, which for the bridges that are touch by the neutron-openvswitch-agent means they will stay in "secure" mode (without any flows defined) even after reboot. This means that the node will be disconnected until neutron-openvswitch-agent is started. To prevent this we now reset the bridge's fail-mode before the interface is coming up. (cherry picked from commit 8229c1e)
(cherry picked from commit e4fc40a)
houndci-bot
reviewed
May 9, 2017
| f.each do |line| | ||
| # There should only be one line of output, the double quoted | ||
| # datapath-id | ||
| res = line.strip.tr('"', '') |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. (https://github.com/SUSE/style-guides/blob/master/Ruby.md#stylestringliterals)
vuntz
changed the title
3 tasks
|
testing on mkcloud environment |
matelakat
approved these changes
Jun 14, 2017
There was a problem hiding this comment.
this change has been tested manually after reproducing the issue. A hard reset-ed network node was unable to join back. With the fix this has been resolved.
Please note that on the test system no bonded interfaces were used.
Please see the notes here: #24 (comment)
|
Build re-triggered: https://ci.suse.de/job/openstack-mkcloud/67487/console |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport crowbar#1041 and crowbar#1161
Fix #24