Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a JSON Schema to Validate "manifest.json" #8

Closed
adamreisberg opened this issue Jul 8, 2020 · 2 comments
Closed

Create a JSON Schema to Validate "manifest.json" #8

adamreisberg opened this issue Jul 8, 2020 · 2 comments

Comments

@adamreisberg
Copy link

In addition to utilizing SAP Help portal for documentation of the manifest.json file used for deployments, create a publicly-accessible JSON Schema to reduce errors in the creation of builds for SAP Commerce.

What a manifest.json JSON Schema support in SAP Commerce/Cloud Portal Looks Like

  1. Freely accessible
  2. Abides by JSON Schema
  3. Support in the manifest.json to reference the schema
    {
     "$schema": "http://example.com/sap-commerce-cloud-schema",
     "commerceSuiteVersion": "1905",
     "extensions": [
         "modeltacceleratorservices"
     ],

Why a JSON Schema for manifest.json?

  1. Reduces build errors from incorrectly formatted manifest.json
  2. Understand value "defaults"
  3. Autocomplete/Correction available where JSON Schema is supported (VSCode)
@mpern
Copy link
Contributor

mpern commented Apr 13, 2021

Since I had similar issues, I've added manifest.json validation to my Commerce Gradle plugin (now part of the SAP open source offering)

https://github.com/SAP/commerce-gradle-plugin/

@adamreisberg
Copy link
Author

@mpern thanks for the feedback. Per your feedback, I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants