Use different namespace_separator with new libexpat #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer version of libexpat have a mitigation for CVE-2022-25236 in place, which disallows the use of certain characters as namespace separators (to my understanding this is the separator used to separate namespace and tag name in the parsed xml output we receive from the library). We implicitly use libexpat via xmltodict.parse(), xmltodict uses a default of ':', which now is invalid. Using ':' as separator results in the following exception: xml.parsers.expat.ExpatError: out of memory: line 1, column 0 This can also be reproduced with this python snippet: xmltodict.parse("<foo></foo>", process_namespaces=True) To mitigate this we need to use a different separator. xmltodict.parse() exposes this as an argument, so passing namespace_separator=' ' (as recommended by libexpat as a char that is not part of an url, see bug reports below or CVE) solves the problem for us. From what I can see this also doesn't require any other changes on our side. Relevant change in libexpat: * libexpat/libexpat#561 Relevant bugreports: * libexpat/libexpat#572 * martinblech/xmltodict#289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer version of libexpat have a mitigation for CVE-2022-25236 in place,
which disallows the use of certain characters as namespace separators
(to my understanding this is the separator used to separate namespace
and tag name in the parsed xml output we receive from the library). We
implicitly use libexpat via xmltodict.parse(), xmltodict uses a default
of ':', which now is invalid. Using ':' as separator results in the
following exception:
xml.parsers.expat.ExpatError: out of memory: line 1, column 0
This can also be reproduced with this python snippet:
xmltodict.parse("", process_namespaces=True)
To mitigate this we need to use a different separator. xmltodict.parse()
exposes this as an argument, so passing namespace_separator=' ' (as
recommended by libexpat as a char that is not part of an url, see bug
reports below or CVE) solves the problem for us. From what I can see
this also doesn't require any other changes on our side.
Relevant change in libexpat:
Relevant bugreports: