Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error tracking #8

Merged
merged 10 commits into from
Mar 30, 2020
Merged

Better error tracking #8

merged 10 commits into from
Mar 30, 2020

Conversation

talal
Copy link
Contributor

@talal talal commented Mar 11, 2020

No description provided.

@talal talal requested a review from majewsky March 11, 2020 10:00
@talal talal marked this pull request as ready for review March 11, 2020 10:13
majewsky
majewsky requested changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Just one thing:

internal/tasks/resource_scrape.go Show resolved Hide resolved
majewsky
majewsky requested changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that I'm overusing the phrase "just one more thing", but I have one more thing. I promise it's the last one.

internal/api/errors.go Show resolved Hide resolved
@talal talal merged commit 505e95a into master Mar 30, 2020
@talal talal deleted the better-error-tracking branch March 30, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majewsky majewsky majewsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@talal @majewsky