Fix new lints #86
Merged
Fix new lints #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These type-safe interfaces around errors.As() and errors.Is() should make it easier to resolve the errorlint warnings without making the code uglier.
majewsky
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
@SuperSandro2000 I added two commits that I would like for you to counter-review. The first adds more type-safe interfaces around errors.As, as we discussed over the lunch break. The second showcases a way that many of the places you marked as nolint can be rewritten to take advantage of errors.Is() without compromising the existing structure too much. Please take this change under consideration for the application repos, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.