upgrade tooling to 2022 standards #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the commit with the same name in Maia yesterday, though significantly less invasive since Hermes' tooling was in better shape beforehand. Note that the Dockerfile uses references to Docker Hub instead of our internal Keppel instance. When you merge this, you want to change your pipeline to chain ci/shared/task-inject-dockerhub-mirror in front of the build job (cf. any of my own pipelines).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per @notque's request, this gives Hermes the same treatment as sapcc/maia#78.
Note that the Dockerfile uses references to Docker Hub instead of our internal Keppel instance. When you merge this, you want to change your pipeline to chain ci/shared/task-inject-dockerhub-mirror in front of the build job (cf. any of my own pipelines).
This moves to the golangci-lint config generated by go-makefile-maker, which is stricter than the previous one. I've fixed most of the new lints. The two instances where I added a
nolintwould be solved by using the respective APIs from sapcc/go-bits, but let's do this step first before going there.