upgrade tooling to 2022 standards #78
Conversation
@notque This should help you get started. There are a billion little lint errors in `make check` that you should fix before merging this, but the test suite itself (`make build/cover.html`) passes. Note that the Dockerfile uses references to Docker Hub instead of our internal Keppel instance. When you merge this, you want to change your pipeline to chain ci/shared/task-inject-dockerhub-mirror in front of the build job (cf. any of my own pipelines).
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Make check passed, but looks like their are additional ones. Will continue shortly |
unsure exactly how to fix the tests, and I would like to get this loaded and running asap. There are many todos i left over, and some ugly code, but getting the rest of this in seems far more important.
|
Still erroring, what is the most reasonable way to remove typecheck so that the tests file don't fail on mock drivers. I'd like to get this and hermes merged, and loaded up and running tomorrow in qa so that i can validate everything works, and we get this far. there are obviously lots of todos, and some real ugly lint changes that i need to sort out, but at least to me it seems reasonable enough to move forward with. |
That's not really possible since typecheck is a prerequisite for all the other checks. The root cause was that code generation was not running as part of |
@notque This should help you get started. There are a billion little lint errors in
make checkthat you should fix before merging this, but the test suite itself (make build/cover.html) passes.Note that the Dockerfile uses references to Docker Hub instead of our internal Keppel instance. When you merge this, you want to change your pipeline to chain ci/shared/task-inject-dockerhub-mirror in front of the build job (cf. any of my own pipelines).
Edit: If any of the golangci-lint checks annoy you particularly, you can switch
golangciLint.createConfigto false in Makefile.maker.yaml and then turn off the respective checks in the golangci-lint config file. The set that we have active right now is the default selection that we use for most of our services. Most annoying lints can also be resolved by generously sprinkling nolint comments on the codebase wherever justified, see golangci-lint docu for details.