Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use quota_usage endpoint in Octavia API instead of counting. #111

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Use quota_usage endpoint in Octavia API instead of counting. #111

merged 1 commit into from
Jun 17, 2021

Conversation

velp
Copy link
Contributor

@velp velp commented May 26, 2021 •
edited by majewsky
Loading

This PR changes scraping for Octavia quota usage metrics to use new endpoint quota_usage instead of counting resources one by one.

Based on sapcc/octavia#16

⚠️DO NOT MERGE THIS PR BEFORE OCTAVIA'S ONE⚠️

Checklist:

  • If this PR is about a plugin, I tested the plugin against an OpenStack cluster.
  • I updated the documentation to describe the semantical or interface changes I introduced.

@velp velp requested a review from majewsky May 26, 2021 16:42
@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.031% when pulling 34b4905 on use_octavia_quota_usage into 8b18694 on master.

@majewsky
Copy link
Contributor

Looks good. I will apply this when the quota usage endpoint is rolled out to prod.

@majewsky majewsky merged commit 34b4905 into master Jun 17, 2021
@majewsky majewsky deleted the use_octavia_quota_usage branch June 17, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majewsky majewsky Awaiting requested review from majewsky majewsky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@velp @coveralls @majewsky