Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include swift-recon sharding metrics #122

Merged
merged 7 commits into from
Oct 24, 2023
Merged

include swift-recon sharding metrics #122

merged 7 commits into from
Oct 24, 2023

Conversation

c-g-b
Copy link
Contributor

@c-g-b c-g-b commented Oct 23, 2023

No description provided.

@c-g-b c-g-b requested a review from talal October 23, 2023 08:00
majewsky
majewsky requested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's on the right track, but I have some questions on underdocumented parts that do surprising things.

Also, please take care of the linter errors. You can run them locally with make static-check.

internal/collector/recon/sharding.go Show resolved Hide resolved
internal/collector/recon/sharding.go Outdated Show resolved Hide resolved
internal/collector/recon/sharding.go Outdated Show resolved Hide resolved
internal/collector/recon/utils.go Outdated Show resolved Hide resolved
c-g-b and others added 5 commits October 23, 2023 10:59
@c-g-b
fix formatting, add comments
6a72eac
@c-g-b
modify test cases
e5c142d
@majewsky
elevate the fix for 'None' string literals into a general rule
c1c4d1e 
This is very safe to do in the general case since ""None"" is very
obviously a JSON syntax error, and having it here next to where the
problem is caused is clearer than having a special override in a
completely different place.
@c-g-b
remove escape stripping
4ff25cd
@c-g-b
fix inline comments
4840422
@majewsky majewsky merged commit 60f0c77 into master Oct 24, 2023
6 checks passed
@majewsky majewsky deleted the container-sharding-metrics branch October 24, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majewsky majewsky majewsky approved these changes

@talal talal Awaiting requested review from talal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c-g-b @majewsky