-
-
Notifications
You must be signed in to change notification settings - Fork 210
-
-
Notifications
You must be signed in to change notification settings - Fork 210
class names associated with incorrect icon #91
Comments
I don't have this issue, can you give us your icons eventually (+ grunt config) ? |
Do you use default |
Same problem here. My gruntfile: webfont: {
icons: {
src: 'assets/img/svg/*.svg',
dest: 'assets/fonts',
destCss: 'assets/sass',
options: {
font: 'IconsFont',
stylesheet: 'scss'
}
}
}, See the generated preview: https://dl.dropboxusercontent.com/u/15052756/iconsfont.JPG You will see that the telefone icon is not what it should be. *** Update: Just downgraded to 0.2.2 (npm install grunt-webfont@0.2.2 --save-dev) and the icons are in the correct order. So the issue is related to 0.3.0. |
Thanks! I’ll look at it. |
hey - i've just tried to create a simple sample project with the same problem and failed... which means 0.3.0 seems to work out of the box. i'm wondering if it is something as simple as the css being cached and not updating properly :s I should be able to confirm this at work tomorrow. |
on my mac this seemed to work ok. on linux how ever I still run into this problem. I'm guessing fontforge version isn't the problem?
If you wanted to see the problem, I am using grunt-webfont in this project and have created a webfont branch:
Let me know if you would like me to trim an example project down to bare-bones fonts? |
I have the same problem in linux. With the 0.2.2 version works fine, but since version 3 does not work |
@nicomollet I can’t reproduce it with your SVGs and config: http://cl.ly/image/3M1u0b0n2X03 |
@peter-mouland It would be very useful if you still experience this problem. Thanks! |
@sapegin Fontforge seems to be: 25-Feb-2011-ML |
on my mac fontforge is:
on my linux vm fontforge is:
I have created a small jekyll project that demos this problem: |
ive just finished updating fontforge to the following:
(which was a massive pain as sudo apt-get retrieves an old version) unfortunately this doesnt affect the outcome |
to take a comment from issue #101 , if i turn ligatures on, it almost fixes the problem on linux, but then any font class which contains a dash in incorrect. Again, this issue isn't replicated onto my mac with the same code. |
@tcditgens I thought that different sorting is the reason and planned to make bigger refactoring. But if this works I could make it first. |
I hope it’s fixed in 0.3.3. Could anybody try it? |
changing the I've has a play with basically: |
I was able to get the css version to use integers by making this change. dtipson@96a7df8 The content:"\e001" versions were all squares for me, unfortunately. |
My change is obviously wrong too, as parseInt('e006',16) is 57350, not 5734A. Wish I knew more about converting unicode ranges... |
Tried to figure it out, and hexadecimal addition in javascript is just beyond me. To be fair, the gylph name for the glyphs in the .svg version of the generated font (example, \u57345-\u5734B, though without the u when actually used as a CSS escape) is what seems to work for the PUA range for css in chrome, rather than what's currently output (example of same range: \e001-\e007). But I can't figure out what's generating that and how to map that same functionality onto what webfont.js is doing. |
Ok, this fixed things for me: Basically, translates the start integer into a format that the .toString(16) function can act upon. |
👍 for dtipson/grunt-webfont@2cd746d Fixed unicode numbering output. |
Cool, the guys have tested dtipson/grunt-webfont@2cd746d on our linux project and it is fixed for us 👍 |
I've noticed that a few updates have been done recently, would you like us to use the git version and confirm the latest version has fixed the above issues on linux + mac? If its fixed we could also confirm all the '... fonts dont display on [android/chrome/mac] ... ' issues that have been opened recently |
It would be awesome 👍 |
2cd746d fixed to me o/ |
2cd746d fixed me too (on mac) |
Great! I’ve just published new release to npm. |
@sapegin working on 0.3.4 version! |
I still have this problem on mac osx using the 0.3.4: here is the config in my gruntfile
Setting ligatures as true, the order is correct and everything works fine, and each names corresponds to the right icon. |
@luruke Could you send me your icons/gruntfile that I could debug? |
@luruke I’t already fixed in master branch but I finally could reproduce it and add some tests. Thanks! |
I have noticed when using v0.3.0 the ordering of the class names are now alphabetical (nice touch), but unfortunately the wrong icons are displayed next to the class name.
The icons seem to be in the same order they would have been in 0.2.2.
The text was updated successfully, but these errors were encountered: