-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using webpack file-loader doesn't work with styleguidist #82
Comments
Could you please share your Styleguidist config and |
var path = require('path');
var projectWebpackConfig = require('./webpack.config');
module.exports = {
rootDir: './web/ui',
components: './atoms/**/*.js',
getExampleFilename: function(componentpath) {
return path.join(path.dirname(componentpath), 'README.md');
},
getComponentPathLine: function(componentpath) {
var name = path.basename(componentpath, '.js');
var dir = path.dirname(componentpath);
return 'import ' + name + ' from \'' + dir + '\';';
},
updateWebpackConfig: function(webpackConfig, env) {
// Add scss loader.
webpackConfig.module.loaders = webpackConfig.module.loaders.concat(
[{ test: /\.js$/, exclude: /node_modules/, loaders: ['babel'] }],
[projectWebpackConfig.EXPORT.scssLoader],
projectWebpackConfig.EXPORT.fontLoaders
);
webpackConfig.resolve.alias['rsg-components/StyleGuide'] = path.join(
__dirname, 'web/styleguide/StyleGuide');
return webpackConfig;
},
};
|
Could you try 2.0.0-rc3? It’s possible the we have a fix for that:
|
I get a new error, probably because I'm on Babel 5 so far and styleguidist 2 requires Babel 6.
I hope to get the time migrating to Babel 6 sometime soon. |
Yeah, it should be because of Babel 5. Not sure we can detect it and show a meaningful warning. |
I won't be able to migrate anytime soon on this project. So I'm happy if you want to close the ticket. Otherwise I might report back here in a few months how things turned out. |
Feel free to reopen if you have issues in the future. |
Hi, thanks for this nice tool!
I tried to integrate a webfont into my styles and configured webpack (also the styleguide webpack config) to load fonts like this:
This works well for my normal webpack setup in developmernt but fails when using
styleguidist server
andstyleguidist build
. When I view the styleguide, it just doesn't pick up my custom webfont, but uses the system fallback.I don't get any errors for the SCSS compilation and no webpack loader errors, so I'm sure the paths to the font files are correct (again, outside styleguidist, the webpack config works). Now the funny part: if I switch the
file-loader
to out and useurl-loader
then it works!I assume that the styleguidist development server/webpack config doesn't serve the EOT font file correctly. The strange thing on this side though is that I don't get any errors for failing HTTP requests in the Chrome Network tab.
Any ideas on this?
The text was updated successfully, but these errors were encountered: