Fix 761 cell value " x0041 " rendered as "a" #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull latest abap2xlsx changes
Remove doma ZEXCEL_BOOLE01 (abap2xlsx#738)
AUnit warning zcl excel reader huge file "# au > "#au abap2xlsx#739 (abap2xlsx#742)
Synchronize latest changes from master sapmentors/abap2xlsx
These lines are added to method SET_CELL of ZCL_EXCEL_WORKSHEET:
IF lv_value CS '_x'.
" Issue abap2xlsx#761 value "_x0041_" rendered as "A".
" "_x...._", where "." is 0-9 a-f or A-F (case insensitive), is an internal value in sharedStrings.xml
" that Excel uses to store special characters, it's interpreted like Unicode character U+....
" for instance "_x0041_" is U+0041 which is "A".
" To not interpret such text, the first underscore is replaced with "_x005f_".
" The value "_x0041_" is to be stored internally "_x005f_x0041_" so that it's rendered like "_x0041_".
" Note that REGEX is time consuming, it's why "CS" is used above to improve the performance.
REPLACE ALL OCCURRENCES OF REGEX '_(x[0-9a-fA-F]{4}_)' IN lv_value WITH '_x005f_$1' RESPECTING CASE.
ENDIF.
gregorwolf
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lines are added to the method SET_CELL of ZCL_EXCEL_WORKSHEET:
IF lv_value CS 'x'.
" Issue #761 value "x0041" rendered as "A".
" "x....", where "." is 0-9 a-f or A-F (case insensitive), is an internal value in sharedStrings.xml
" that Excel uses to store special characters, it's interpreted like Unicode character U+....
" for instance "x0041" is U+0041 which is "A".
" To not interpret such text, the first underscore is replaced with "x005f".
" The value "x0041" is to be stored internally "x005f_x0041" so that it's rendered like "x0041".
" Note that REGEX is time consuming, it's why "CS" is used above to improve the performance.
REPLACE ALL OCCURRENCES OF REGEX '(x[0-9a-fA-F]{4}_)' IN lv_value WITH 'x005f$1' RESPECTING CASE.
ENDIF.