Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus metrics to Connector (Fixes #146) #392

Merged
merged 12 commits into from
Nov 7, 2019

Conversation

sappenin
Copy link
Collaborator

@sappenin sappenin commented Nov 6, 2019

Fixes #146

  • Adds prometheus metrics tracking for incoming and outgoing packets.
  • Adds Link and PacketSwitch filter unit tests.

Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
…o df/prometheus-log-packets-146

Signed-off-by: David Fuelling <sappenin@gmail.com>

# Conflicts:
#	connector-server/src/main/java/org/interledger/connector/server/spring/settings/SpringConnectorConfig.java
#	connector-server/src/main/java/org/interledger/connector/server/spring/settings/web/SecurityConfiguration.java
Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Nov 6, 2019

This pull request fixes 1 alert when merging a20ae31 into 9c5f4a2 - view on LGTM.com

fixed alerts:

  • 1 for Equals on incomparable types

Signed-off-by: David Fuelling <sappenin@gmail.com>
@sappenin sappenin changed the title Df/prometheus log packets 146 Add Prometheus metrics to Connector (Fixes #146) Nov 6, 2019
@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #392 into master will increase coverage by 2.32%.
The diff coverage is 78.24%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #392      +/-   ##
============================================
+ Coverage     52.63%   54.95%   +2.32%     
- Complexity      655      693      +38     
============================================
  Files           231      239       +8     
  Lines          4334     4595     +261     
  Branches        185      185              
============================================
+ Hits           2281     2525     +244     
- Misses         1983     1999      +16     
- Partials         70       71       +1
Impacted Files Coverage Δ Complexity Δ
...ledger/connector/balances/RedisBalanceTracker.java 80.18% <ø> (ø) 17 <0> (ø) ⬇️
...r/connector/link/http/AbstractBlastHttpSender.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../connector/core/settlement/SettlementQuantity.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...erledger/connector/config/CaffeineCacheConfig.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../interledger/connector/metrics/MetricsService.java 0% <0%> (ø) 0 <0> (?)
...ector/events/IncomingSettlementSucceededEvent.java 0% <0%> (ø) 0 <0> (?)
...onnector/events/IncomingSettlementFailedEvent.java 0% <0%> (ø) 0 <0> (?)
...ledger/connector/link/http/JwtBlastHttpSender.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ts/OutgoingSettlementInitiationSucceededEvent.java 0% <0%> (ø) 0 <0> (?)
...vents/OutgoingSettlementInitiationFailedEvent.java 0% <0%> (ø) 0 <0> (?)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cbd0a8...9927db2. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Nov 6, 2019

This pull request fixes 1 alert when merging aed7eea into 9c5f4a2 - view on LGTM.com

fixed alerts:

  • 1 for Equals on incomparable types

Signed-off-by: David Fuelling <sappenin@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Nov 6, 2019

This pull request fixes 1 alert when merging 8a56ddd into 9c5f4a2 - view on LGTM.com

fixed alerts:

  • 1 for Equals on incomparable types

@lgtm-com
Copy link

lgtm-com bot commented Nov 6, 2019

This pull request fixes 1 alert when merging a35e743 into 1cbd0a8 - view on LGTM.com

fixed alerts:

  • 1 for Equals on incomparable types

* Catch and track InterledgerReject exception properly for metrics
* Rename `OutgoingStatsFilter` to `OutgoingMetricsLinkFilter`.

Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Nov 6, 2019

This pull request fixes 1 alert when merging 00bd178 into 1cbd0a8 - view on LGTM.com

fixed alerts:

  • 1 for Equals on incomparable types

theotherian
theotherian previously approved these changes Nov 6, 2019
Copy link
Collaborator

@theotherian theotherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me; just the one comment to consider on CryptoCompareRateProvider.

* Make fxCache configurable in `CaffeineCacheConfig`
* Wire fxCache properly into `CacheMetricsCollector`.
* Update unit tests.

Signed-off-by: David Fuelling <sappenin@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Nov 7, 2019

This pull request fixes 1 alert when merging 9927db2 into 1cbd0a8 - view on LGTM.com

fixed alerts:

  • 1 for Equals on incomparable types

@sappenin sappenin merged commit 001756b into master Nov 7, 2019
@sappenin sappenin deleted the df/prometheus-log-packets-146 branch November 7, 2019 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log Stats to prometheus
2 participants