-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prometheus metrics to Connector (Fixes #146) #392
Conversation
Signed-off-by: David Fuelling <sappenin@gmail.com>
…o df/prometheus-log-packets-146 Signed-off-by: David Fuelling <sappenin@gmail.com> # Conflicts: # connector-server/src/main/java/org/interledger/connector/server/spring/settings/SpringConnectorConfig.java # connector-server/src/main/java/org/interledger/connector/server/spring/settings/web/SecurityConfiguration.java
Signed-off-by: David Fuelling <sappenin@gmail.com>
This pull request fixes 1 alert when merging a20ae31 into 9c5f4a2 - view on LGTM.com fixed alerts:
|
Signed-off-by: David Fuelling <sappenin@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
============================================
+ Coverage 52.63% 54.95% +2.32%
- Complexity 655 693 +38
============================================
Files 231 239 +8
Lines 4334 4595 +261
Branches 185 185
============================================
+ Hits 2281 2525 +244
- Misses 1983 1999 +16
- Partials 70 71 +1
Continue to review full report at Codecov.
|
This pull request fixes 1 alert when merging aed7eea into 9c5f4a2 - view on LGTM.com fixed alerts:
|
Signed-off-by: David Fuelling <sappenin@gmail.com>
This pull request fixes 1 alert when merging 8a56ddd into 9c5f4a2 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging a35e743 into 1cbd0a8 - view on LGTM.com fixed alerts:
|
* Catch and track InterledgerReject exception properly for metrics * Rename `OutgoingStatsFilter` to `OutgoingMetricsLinkFilter`. Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
This pull request fixes 1 alert when merging 00bd178 into 1cbd0a8 - view on LGTM.com fixed alerts:
|
...src/main/java/org/interledger/connector/javax/money/providers/CryptoCompareRateProvider.java
Outdated
Show resolved
Hide resolved
...mpl/src/test/java/org/interledger/connector/links/filters/OutgoingBalanceLinkFilterTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good to me; just the one comment to consider on CryptoCompareRateProvider
.
* Make fxCache configurable in `CaffeineCacheConfig` * Wire fxCache properly into `CacheMetricsCollector`. * Update unit tests. Signed-off-by: David Fuelling <sappenin@gmail.com>
This pull request fixes 1 alert when merging 9927db2 into 1cbd0a8 - view on LGTM.com fixed alerts:
|
Fixes #146